Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set level of logger dataplane to error #1838

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Set level of logger dataplane to error #1838

merged 1 commit into from
Jul 1, 2020

Conversation

wangxin
Copy link
Collaborator

@wangxin wangxin commented Jul 1, 2020

Description of PR

Summary:
Fixes # (issue)

When we run the fdb/test_fdb.py script, the dataplane logger generats
too much log messages at warning level. Previously we have increased
log level of the dataplane logger to warning. It is still not enough.

This change sets log level of the dataplne logger to error to filter out
the warning messages as well.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To filter out too much unnecessary warning level log messages generated by the dataplane logger when running the fdb/test_fdb.py script.

How did you do it?

Grab the dataplane logger in tests/conftest.py and set its log level to error.

How did you verify/test it?

Test run the fdb/test_fdb.py script, set --log-cli-level to info. No more unnecessary log messages.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

When we run the fdb/test_fdb.py script, the `dataplane` logger generats
**too** much log messages at warning level. This change sets log level
of the `dataplne` logger to error to filter out the warning messages.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
@wangxin wangxin requested a review from a team July 1, 2020 07:24
@wangxin wangxin merged commit 7bfdd0e into sonic-net:master Jul 1, 2020
@wangxin wangxin deleted the logger-dataplane branch July 20, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants