[MgmtVrf ]: fix for Host Unreachable' error

[chitra-raghavan]

Summary:
Fixes #1615

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Approach

What is the motivation for this PR?

How did you do it?

Removed the wait_for after adding mgmt vrf.

How did you verify/test it?

Tested by running in S5232 testbed.

Logs

py.test --inventory=../ansible/lab --host-pattern=sonic-s5232-01 --module-path ../ansible/library/ --testbed=vms-t0-56 --testbed_file=../ansible/testbed.csv test_mgmtvrf.py --log-level=DEBUG --log-file mvrf-debug.log --disable_loganalyzer -rab -vvv
============================= test session starts ==============================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.8.0, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
ansible: 2.8.7
rootdir: /var/johnar/sonic-mgmt/tests, inifile: pytest.ini
plugins: xdist-1.28.0, repeat-0.8.0, forked-1.1.3, ansible-2.2.2
collecting ... collected 10 items

test_mgmtvrf.py::TestMvrfInbound::test_ping PASSED [ 10%]
test_mgmtvrf.py::TestMvrfInbound::test_snmp_fact PASSED [ 20%]
test_mgmtvrf.py::TestMvrfOutbound::test_ping PASSED [ 30%]
test_mgmtvrf.py::TestMvrfOutbound::test_wget PASSED [ 40%]
test_mgmtvrf.py::TestMvrfOutbound::test_curl PASSED [ 50%]
test_mgmtvrf.py::TestServices::test_ntp PASSED [ 60%]
test_mgmtvrf.py::TestServices::test_service_acl PASSED [ 70%]
test_mgmtvrf.py::TestReboot::test_warmboot PASSED [ 80%]
test_mgmtvrf.py::TestReboot::test_reboot PASSED [ 90%]
test_mgmtvrf.py::TestReboot::test_fastboot PASSED [100%]

========================= 10 passed in 1549.91 seconds =========================
Triggering a new build of write_to_csv
Finished: SUCCESS

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging cf5e310 into ce122b6 - view on LGTM.com

new alerts:

• 1 for Variable defined multiple times

fixed alerts:

• 1 for Variable defined multiple times

[chitra-raghavan]

retest this please

[daall]

retest vsimage please

[chitra-raghavan]

retest vsimage please

[chitra-raghavan]

retest vsimage please

[irene-pan1202]

@chitra-raghavan @wangxin
Solution is removed the wait_for after adding mgmt vrf. Why need to add the wait_for SSH stop after deleting mgmt vrf?
Because after deleting mgmt vrf, some models only need 1 second to disconnect, adding this confirmation seems to cause the test timeout. Thanks.