Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[advanced reboot] Add Paramiko module for device connection (#1542) #1551

Conversation

tahmed-dev
Copy link
Contributor

@tahmed-dev tahmed-dev commented Apr 8, 2020

Description of PR

Paramiko module provides fallback mechanism to using username/password
This is required if we are rebooting into new image using advanced
reboot test fixture.

signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Test the change against 201811 with docker mgmt from 201811

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…t#1542)

Parmiko module provides fallback mechanism to using username/password
This is required if we are rebooting into new image using advanced
reboot test fixture.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run a quick test against 201811 image?

@lgtm-com
Copy link

lgtm-com bot commented Apr 8, 2020

This pull request fixes 1 alert when merging 348e08c into 600e59b - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@tahmed-dev
Copy link
Contributor Author

Run a quick test against 201811 image?

Yes, I tested this change against internal 2018 and internal docker mgmt 201811

@tahmed-dev tahmed-dev merged commit a1cc3a5 into sonic-net:201811 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants