Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests/lag]: Convert lag_fallback.yml to pytest #1526

Merged
merged 3 commits into from
Apr 9, 2020
Merged

[tests/lag]: Convert lag_fallback.yml to pytest #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde8551
[tests/lag]: Convert lag_fallback.yml to pytest
Blueve Apr 2, 2020
bffe089
Use EOSHost shutdown/no_shutdown method instead local function
Blueve Apr 9, 2020
bb434bd
Fix typos and LGTM violations
Blueve Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tests/common/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,15 +371,24 @@ def shutdown(self, interface_name):
out = self.host.eos_config(
lines=['shutdown'],
parents='interface %s' % interface_name)
logging.info('Shut interface [%s]' % interface_name)
return out
if not self.check_intf_link_state(interface_name):
logging.info('Shut interface [%s]' % interface_name)
return out
raise RunAnsibleModuleFail("The interface state is Up but expect Down, detail output: %s" % out[self.hostname])

def no_shutdown(self, interface_name):
out = self.host.eos_config(
lines=['no shutdown'],
parents='interface %s' % interface_name)
logging.info('No shut interface [%s]' % interface_name)
return out
if self.check_intf_link_state(interface_name):
logging.info('No shut interface [%s]' % interface_name)
return out
raise RunAnsibleModuleFail("The interface state is Down but expect Up, detail output: %s" % out[self.hostname])

def check_intf_link_state(self, interface_name):
show_int_result = self.host.eos_command(
commands=['show interface %s' % interface_name])[self.hostname]
return 'Up' in show_int_result['stdout_lines'][0]

class FanoutHost():
"""
Expand Down
73 changes: 68 additions & 5 deletions tests/test_lag_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,23 @@ def test_lag_2(common_setup_teardown, nbrhosts):
try:
lag_facts['lags'][lag_name]['po_config']['runner']['min_ports']
except:
logging.info("Skip [check_single_lap_lacp_rate] for lag (%s) due to min_ports not exists" % lag_name)
logging.info("Skip [check_single_lap] for lag (%s) due to min_ports not exists" % lag_name)
logging.info("Skip [check_single_lag_lacp_rate] for lag (%s) due to min_ports not exists" % lag_name)
logging.info("Skip [check_single_lag] for lag (%s) due to min_ports not exists" % lag_name)
continue
else:
check_single_lag_lacp_rate(common_setup_teardown, nbrhosts, lag_name)
check_single_lag(common_setup_teardown, nbrhosts, lag_name)

try:
lag_facts['lags'][lag_name]['po_config']['runner']['fallback']
except:
logging.info("Skip [check_lag_fallback] for lag (%s) due to fallback was not set for it" % lag_name)
else:
check_lag_fallback(common_setup_teardown, nbrhosts, lag_name)

def check_single_lag_lacp_rate(common_setup_teardown, nbrhosts, lag_name):
duthost, ptfhost, vm_neighbors, mg_facts, lag_facts, fanout_neighbors = common_setup_teardown
logging.info("Start checking single lap lacp rate for: %s" % lag_name)
logging.info("Start checking single lag lacp rate for: %s" % lag_name)

intf, po_interfaces = get_lag_intfs(lag_facts, lag_name)
peer_device = vm_neighbors[intf]['name']
Expand Down Expand Up @@ -101,7 +108,7 @@ def check_single_lag_lacp_rate(common_setup_teardown, nbrhosts, lag_name):

def check_single_lag(common_setup_teardown, nbrhosts, lag_name):
duthost, ptfhost, vm_neighbors, mg_facts, lag_facts, fanout_neighbors = common_setup_teardown
logging.info("Start checking single lap for: %s" % lag_name)
logging.info("Start checking single lag for: %s" % lag_name)

intf, po_interfaces = get_lag_intfs(lag_facts, lag_name)
po_flap = check_flap(lag_facts, lag_name)
Expand All @@ -119,6 +126,62 @@ def check_single_lag(common_setup_teardown, nbrhosts, lag_name):
vm_host = nbrhosts[peer_device]
verify_lag_minlink(duthost, vm_host, lag_name, peer_device, intf, neighbor_interface, po_interfaces, po_flap, deselect_time=95)

def check_lag_fallback(common_setup_teardown, nbrhosts, lag_name):
duthost, ptfhost, vm_neighbors, mg_facts, lag_facts, fanout_neighbors = common_setup_teardown
logging.info("Start checking lag fall back for: %s" % lag_name)
intf, po_interfaces = get_lag_intfs(lag_facts, lag_name)
po_fallback = lag_facts['lags'][lag_name]['po_config']['runner']['fallback']

# Figure out remote VM and interface info for the lag member and run lag fallback test
peer_device = vm_neighbors[intf]['name']
neighbor_interface = vm_neighbors[intf]['port']
vm_host = nbrhosts[peer_device]

try:
# Shut down neighbor interface
vm_host.shutdown(neighbor_interface)
time.sleep(120)

# Refresh lag facts
lag_facts = duthost.lag_facts(host = duthost.hostname)['ansible_facts']['lag_facts']

# Get teamshow result
teamshow_result = duthost.shell('teamshow')
logging.info("Teamshow result: %s" % teamshow_result)

# Verify lag members
# 1. All other lag should keep selected state
# 2. Shutdown port should keep selected state if fallback enabled
# 3. Shutdown port should marded as deselected if fallback disabled
# is marked deselected for the shutdown port and all other lag member interfaces are marked selected
for po_intf in po_interfaces.keys():
if po_intf != intf or po_fallback:
assert lag_facts['lags'][lag_name]['po_stats']['ports'][po_intf]['runner']['selected']
else:
assert not lag_facts['lags'][lag_name]['po_stats']['ports'][po_intf]['runner']['selected']

# The portchannel should marked Up/Down correctly according to po fallback setting
if po_fallback:
assert lag_facts['lags'][lag_name]['po_intf_stat'] == 'Up'
else:
assert lag_facts['lags'][lag_name]['po_intf_stat'] == 'Down'

finally:
# Bring up neighbor interface
vm_host.no_shutdown(neighbor_interface)
time.sleep(30)

# Refresh lag facts
lag_facts = duthost.lag_facts(host = duthost.hostname)['ansible_facts']['lag_facts']

# Verify all interfaces in port_channel are marked up
for po_intf in po_interfaces.keys():
assert lag_facts['lags'][lag_name]['po_stats']['ports'][po_intf]['link']['up'] == True

# Verify portchannel interface are marked up correctly
assert lag_facts['lags'][lag_name]['po_intf_stat'] == 'Up'


def verify_lag_lacp_timing(ptfhost, vm_name, lacp_timer, exp_iface):
if exp_iface is None:
return
Expand Down Expand Up @@ -162,7 +225,7 @@ def verify_lag_minlink(
# Refresh lag facts
lag_facts = duthost.lag_facts(host = duthost.hostname)['ansible_facts']['lag_facts']

# Verify lag member is marked deselected for the shutdown porta and all other lag member interfaces are marked selected
# Verify lag member is marked deselected for the shutdown port and all other lag member interfaces are marked selected
for po_intf in po_interfaces.keys():
if po_intf != intf:
assert lag_facts['lags'][lag_name]['po_stats']['ports'][po_intf]['runner']['selected']
Expand Down