add ptfhost check to prevent failure on test_posttest.py #14783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTFHost can be None in some cases (eg. ixia) and this was not handled correctly in test_collect_ptf_logs. Add ptfhost check to prevent error caused by None value.
|
@augusdn PR conflicts with 202405 branch |
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…onic-net#14783) PTFHost can be None in some cases (eg. ixia) and this was not handled correctly in test_collect_ptf_logs. Add ptfhost check to prevent error caused by None value. PTFHost can be None in some cases (eg. ixia) and this was not handled correctly in test_collect_ptf_logs. Add ptfhost check to prevent error caused by None value. Description of PR Summary: PTFHost can be None in some cases (eg. ixia) and this was not handled correctly in test_collect_ptf_logs. Add ptfhost check to prevent error caused by None value. Approach What is the motivation for this PR? Resolve unexpected error during log collection How did you do it? check for None value co-authorized by: jianquanye@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTFHost can be None in some cases (eg. ixia) and this was not handled correctly in test_collect_ptf_logs. Add ptfhost check to prevent error caused by None value.
Description of PR
Summary:
PTFHost can be None in some cases (eg. ixia) and this was not handled correctly in test_collect_ptf_logs. Add ptfhost check to prevent error caused by None value.
Type of change
Back port request
Approach
What is the motivation for this PR?
Resolve unexpected error during log collection
How did you do it?
check for None value
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation