Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:13066] [BGP Memory Leak] Add FRR memory checker in the continuous link flap test #14234

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
This is to cover the BGP memory leak test gap.
Previously we have an issue in FRR(FRRouting/frr#15459), which caused memory leak.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

This is to cover the BGP memory leak test gap.

How did you do it?

I added a checker for the FRR daemons(bgpd and zebra) used memory in the test test_cont_link_flap.py. The reason why I added the checker in test_cont_link_flap.py but not the stress route test, is because we already have some memory and cpu checkers in the link flap test. And the link flap also causes routes announce/withdraw like what we have in the stress route test.

How did you verify/test it?

Run the test and it passed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…test (sonic-net#13066)

* Add bgp memory checker in the continuous link flap test
@mssonicbld
Copy link
Collaborator Author

Original PR: #13066

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 7f07449 into sonic-net:202405 Aug 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants