Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:12719] port_alias.py: Handle port_config.ini header change #13374

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mssonicbld
Copy link
Collaborator

In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed:

- # name lanes alias index role speed asic_port_name coreId corePortId numVoq
+ # name lanes alias index role speed asic_port_name core_id core_port_id num_voq

But port_alias.py depends on the header names and wasn't updated:

ALLOWED_HEADER = ['name', 'lanes', 'alias', 'index', 'asic_port_name', 'role', 'speed',
 'coreid', 'coreportid', 'numvoq']

This PR updates port_alias.py to account for the port_config.ini change.

Summary:
Fixes #12718

Type of change

[x] Bug fix

…onic-net#12719)

In sonic-net/sonic-buildimage#18704 the header of port_config.ini was changed:

- # name              lanes     alias               index  role   speed    asic_port_name     coreId     corePortId     numVoq
+ # name              lanes     alias               index  role   speed    asic_port_name     core_id     core_port_id     num_voq
But port_alias.py depends on the header names and wasn't updated:

ALLOWED_HEADER = ['name', 'lanes', 'alias', 'index', 'asic_port_name', 'role', 'speed',
                  'coreid', 'coreportid', 'numvoq']
This PR updates port_alias.py to account for the port_config.ini change.

Summary:
Fixes sonic-net#12718

Type of change
@mssonicbld
Copy link
Collaborator Author

Original PR: #12719

@mssonicbld mssonicbld merged commit c9ffb8d into sonic-net:202205 Jun 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants