[dhcp_relay] Add link state change tests #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enhance DHCP relay test to ensure relay agent is robust enough to handle link state changes and starting up when configured links are down. This test validates the bug fix in sonic-net/sonic-buildimage#3851 and should help prevent regressions.
Type of change
Approach
How did you do it?
After the standard DHCP relay test, run two more tests, as follows:
How did you verify/test it?
Tested on a DUT with and without the patch mentioned above. Without the patch, the test fails; with the patch, the test succeeds.