Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sonic yangs during pipeline build #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,28 @@ trigger:
branches:
include:
- master
- 202???

pr:
branches:
include:
- master
- 202???

variables:
- name: BUILD_BRANCH
${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
value: $(System.PullRequest.TargetBranch)
${{ else }}:
value: $(Build.SourceBranchName)

resources:
repositories:
- repository: sonic-mgmt-common
type: github
name: sonic-net/sonic-mgmt-common
endpoint: sonic-net
ref: refs/heads/$(BUILD_BRANCH)

stages:
- stage: Build
Expand All @@ -42,18 +52,19 @@ stages:
- checkout: sonic-mgmt-common
clean: true
submodules: recursive
displayName: 'Checkout code'
displayName: 'Checkout sonic-mgmt-common'

- task: DownloadPipelineArtifact@2
inputs:
source: specific
project: build
pipeline: 1
pipeline: 142
artifact: sonic-buildimage.vs
runVersion: 'latestFromBranch'
runBranch: 'refs/heads/master'
runBranch: 'refs/heads/$(BUILD_BRANCH)'
patterns: |
target/debs/buster/libyang*.deb
target/python-wheels/bullseye/sonic_yang_models*.whl
Copy link
Contributor

@kwangsuk kwangsuk Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you learn a Debian distribution on the fly instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any references? I could not find another such instance.

Not sure how to determine it generically. Did not find any settings in debian/control or any other setting files under sonic-mgmt-framework repo. As per my understanding the target debian version is chosen buy the docker build rules file, by adding the docker image file name to different makefile variables -- like here and here. These docker makefiles are not used during pipeline builds. In fact we do not download sonic-buildimage code as well. Even if we donwload we cannot invoke these makefiles directly. Also, the code pattern is not generic enough to grep & determine the debian version.

displayName: "Download sonic buildimage"

- script: |
Expand All @@ -80,18 +91,21 @@ stages:
[[ ! -f python3_requirements.txt ]] || \
sudo pip3 install --no-cache-dir -r python3_requirements.txt
popd
displayName: "Install dependency"
- script: |
sudo pip3 install ../target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
displayName: "Install sonic yangs"
- script: |
set -ex
pushd sonic-mgmt-common
NO_TEST_BINS=1 dpkg-buildpackage -rfakeroot -b -us -uc -j$(nproc)
displayName: "Install dependency"
displayName: "Build sonic-mgmt-common"
- script: |
set -ex
ls -l
pushd sonic-mgmt-framework
dpkg-buildpackage -rfakeroot -us -uc -b -j$(nproc) && cp ../*.deb $(Build.ArtifactStagingDirectory)/
Expand Down