Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[link prober] print out error code message when sendHeartbeat fails #266

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

zjswhhh
Copy link
Contributor

@zjswhhh zjswhhh commented Aug 7, 2024

Description of PR

Summary:
Fixes # (issue)
Print out error code message when sendHeartbeat fails.

sign-off: Jing Zhang zhangjing@microsoft.com

Type of change

  • Bug fix
  • New feature
  • Doc/Design
  • Unit test

Approach

What is the motivation for this PR?

Work item tracking
  • Microsoft ADO (number only):

How did you do it?

How did you verify/test it?

Any platform specific information?

Documentation

Copy link
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to catch the I/O error in the receive?

Copy link
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjswhhh zjswhhh merged commit 287dbd7 into sonic-net:master Aug 13, 2024
9 checks passed
@zjswhhh zjswhhh deleted the master_ec branch August 13, 2024 17:32
mssonicbld pushed a commit to mssonicbld/sonic-linkmgrd that referenced this pull request Aug 23, 2024
…sonic-net#266)

Summary:
Fixes # (issue)
Print out error code message when sendHeartbeat fails.

sign-off: Jing Zhang zhangjing@microsoft.com
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #271

mssonicbld pushed a commit that referenced this pull request Aug 24, 2024
…#266)

Summary:
Fixes # (issue)
Print out error code message when sendHeartbeat fails.

sign-off: Jing Zhang zhangjing@microsoft.com
mssonicbld pushed a commit to mssonicbld/sonic-linkmgrd that referenced this pull request Aug 28, 2024
…sonic-net#266)

Summary:
Fixes # (issue)
Print out error code message when sendHeartbeat fails.

sign-off: Jing Zhang zhangjing@microsoft.com
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #276

yxieca pushed a commit that referenced this pull request Aug 28, 2024
…#266) (#276)

Summary:
Fixes # (issue)
Print out error code message when sendHeartbeat fails.

sign-off: Jing Zhang zhangjing@microsoft.com

Co-authored-by: Jing Zhang <zhangjing@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants