[active-standby] Fix the oscillation logic #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
yxieca
reviewed
Jul 1, 2024
yxieca
previously approved these changes
Jul 1, 2024
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
yxieca
approved these changes
Jul 2, 2024
|
@lolyu do we not need this change in 202311? |
Was the issue found in production or nightly? |
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Aug 23, 2024
Approach What is the motivation for this PR? Fix the unexpected toggle introduced by the oscillation logic. Signed-off-by: Longxiang Lyu lolv@microsoft.com Work item tracking Microsoft ADO (number only): 28397786 How did you do it? The oscillation is introduced to allow the active side to toggle to standby if no heartbeat is received. The workflow is described as the following: (wait, active, up) ---> set oscillation timer [1] ... (wait, active, up) ---> (wait, wait, up) [2] (wait, wait, up) ---> (wait, active, up) ... (wait, active, up) <--- oscillation timer expires, toggle to standby [3] [1]: the ToR enters (wait, active, up), no heartbeats received, oscillation timer is set. [2]: the ToR consistently probes the mux status, and transits between (wait, active, up) and (wait, wait, up). [3]: when the oscillation timer expires and the ToR is (wait, active, up), make the toggle to standby request. We need to ensure that, the ToR is only allowed to transits between (wait, active, up) and (wait, wait, up) during [2]. So any link prober active/standby, mux standby, or link down events should cancel the oscillation. How did you verify/test it? UT Any platform specific information? Documentation
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Aug 23, 2024
Approach What is the motivation for this PR? Fix the unexpected toggle introduced by the oscillation logic. Signed-off-by: Longxiang Lyu lolv@microsoft.com Work item tracking Microsoft ADO (number only): 28397786 How did you do it? The oscillation is introduced to allow the active side to toggle to standby if no heartbeat is received. The workflow is described as the following: (wait, active, up) ---> set oscillation timer [1] ... (wait, active, up) ---> (wait, wait, up) [2] (wait, wait, up) ---> (wait, active, up) ... (wait, active, up) <--- oscillation timer expires, toggle to standby [3] [1]: the ToR enters (wait, active, up), no heartbeats received, oscillation timer is set. [2]: the ToR consistently probes the mux status, and transits between (wait, active, up) and (wait, wait, up). [3]: when the oscillation timer expires and the ToR is (wait, active, up), make the toggle to standby request. We need to ensure that, the ToR is only allowed to transits between (wait, active, up) and (wait, wait, up) during [2]. So any link prober active/standby, mux standby, or link down events should cancel the oscillation. How did you verify/test it? UT Any platform specific information? Documentation
|
Cherry-pick PR to 202405: #269 |
|
Cherry-pick PR to 202311: #270 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 23, 2024
Approach What is the motivation for this PR? Fix the unexpected toggle introduced by the oscillation logic. Signed-off-by: Longxiang Lyu lolv@microsoft.com Work item tracking Microsoft ADO (number only): 28397786 How did you do it? The oscillation is introduced to allow the active side to toggle to standby if no heartbeat is received. The workflow is described as the following: (wait, active, up) ---> set oscillation timer [1] ... (wait, active, up) ---> (wait, wait, up) [2] (wait, wait, up) ---> (wait, active, up) ... (wait, active, up) <--- oscillation timer expires, toggle to standby [3] [1]: the ToR enters (wait, active, up), no heartbeats received, oscillation timer is set. [2]: the ToR consistently probes the mux status, and transits between (wait, active, up) and (wait, wait, up). [3]: when the oscillation timer expires and the ToR is (wait, active, up), make the toggle to standby request. We need to ensure that, the ToR is only allowed to transits between (wait, active, up) and (wait, wait, up) during [2]. So any link prober active/standby, mux standby, or link down events should cancel the oscillation. How did you verify/test it? UT Any platform specific information? Documentation
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Aug 23, 2024
Approach What is the motivation for this PR? Fix the unexpected toggle introduced by the oscillation logic. Signed-off-by: Longxiang Lyu lolv@microsoft.com Work item tracking Microsoft ADO (number only): 28397786 How did you do it? The oscillation is introduced to allow the active side to toggle to standby if no heartbeat is received. The workflow is described as the following: (wait, active, up) ---> set oscillation timer [1] ... (wait, active, up) ---> (wait, wait, up) [2] (wait, wait, up) ---> (wait, active, up) ... (wait, active, up) <--- oscillation timer expires, toggle to standby [3] [1]: the ToR enters (wait, active, up), no heartbeats received, oscillation timer is set. [2]: the ToR consistently probes the mux status, and transits between (wait, active, up) and (wait, wait, up). [3]: when the oscillation timer expires and the ToR is (wait, active, up), make the toggle to standby request. We need to ensure that, the ToR is only allowed to transits between (wait, active, up) and (wait, wait, up) during [2]. So any link prober active/standby, mux standby, or link down events should cancel the oscillation. How did you verify/test it? UT Any platform specific information? Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #253
Type of change
Approach
What is the motivation for this PR?
Fix the unexpected toggle introduced by the oscillation logic.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
Work item tracking
How did you do it?
The oscillation is introduced to allow the active side to toggle to standby if no heartbeat is received.
The workflow is described as the following:
[1]: the ToR enters
(wait, active, up), no heartbeats received, oscillation timer is set.[2]: the ToR consistently probes the mux status, and transits between
(wait, active, up)and(wait, wait, up).[3]: when the oscillation timer expires and the ToR is
(wait, active, up), make the toggle to standby request.We need to ensure that, the ToR is only allowed to transits between
(wait, active, up)and(wait, wait, up)during [2]. So any link prober active/standby, mux standby, or link down events should cancel the oscillation.How did you verify/test it?
UT
Any platform specific information?
Documentation