Fix state machine handler race conditions introduced by strand::wrap
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolyu
force-pushed
the
fix_race_with_strand_wrap
branch
2 times, most recently
from
e37ec72
to
abc122f
Compare
|
cannot repro the UT failure on local device, will investigate soon. |
lolyu
changed the title
strand::wrapstrand::wrap
|
@lolyu please look into the checker failures. |
Sure, it is a pretty tricky regression due to the change, will fix soon. |
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
force-pushed
the
fix_race_with_strand_wrap
branch
2 times, most recently
from
28c057a
to
34ac1e0
Compare
lolyu
force-pushed
the
fix_race_with_strand_wrap
branch
from
a74a321
to
b16de0f
Compare
lolyu
changed the title
strand::wrapstrand::wrap
the PR description is there |
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Aug 23, 2024
sonic-net#257) Approach What is the motivation for this PR? As the subject. Work item tracking Microsoft ADO (number only): 28585413 How did you do it? Post the handler directly to handler instead of calling it with strand::wrap How did you verify/test it? UT Any platform specific information? Documentation
|
Cherry-pick PR to 202405: #272 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 24, 2024
#257) Approach What is the motivation for this PR? As the subject. Work item tracking Microsoft ADO (number only): 28585413 How did you do it? Post the handler directly to handler instead of calling it with strand::wrap How did you verify/test it? UT Any platform specific information? Documentation
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Aug 28, 2024
sonic-net#257) Approach What is the motivation for this PR? As the subject. Work item tracking Microsoft ADO (number only): 28585413 How did you do it? Post the handler directly to handler instead of calling it with strand::wrap How did you verify/test it? UT Any platform specific information? Documentation
|
Cherry-pick PR to 202311: #274 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2024
#257) Approach What is the motivation for this PR? As the subject. Work item tracking Microsoft ADO (number only): 28585413 How did you do it? Post the handler directly to handler instead of calling it with strand::wrap How did you verify/test it? UT Any platform specific information? Documentation
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
As the subject.
Work item tracking
How did you do it?
Post the handler directly to handler instead of calling it with
strand::wrapHow did you verify/test it?
UT
Any platform specific information?
Documentation