Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ZMQ to GNMI to improve Dash GNMI API performance. #135

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Jul 17, 2023

Integrate ZMQ to GNMI to improve Dash GNMI API performance.

Why I did it

Currently Dash gnmi to orchagent communitcation using redis based channel, switch to ZMQ based change will improve performance.

How I did it

Integrate ZMQ to gnmi service.

How to verify it

Manually test.
Add new UT.

Work item tracking

Microsoft ADO (number only): 17753835

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Integrate ZMQ to GNMI to improve Dash GNMI API performance.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 18, 2023

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 135 in repo sonic-net/sonic-gnmi

@liuh-80 liuh-80 requested a review from ganglyu July 18, 2023 06:37
@liuh-80 liuh-80 marked this pull request as ready for review July 18, 2023 06:37
@liuh-80 liuh-80 requested a review from qiluo-msft July 18, 2023 06:40
ganglyu
ganglyu previously approved these changes Jul 18, 2023
Copy link
Contributor

@ganglyu ganglyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liuh-80 liuh-80 closed this Jul 18, 2023
@liuh-80 liuh-80 reopened this Jul 18, 2023
@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 19, 2023

/easycla

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 19, 2023

/azp run EasyCLA

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 135 in repo sonic-net/sonic-gnmi

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 19, 2023

EasyCLA not run because a known issue: communitybridge/easycla#4052

@jarias-lfx
Copy link

/easycla

sonic_data_client/mixed_db_client.go Outdated Show resolved Hide resolved
sonic_data_client/mixed_db_client.go Outdated Show resolved Hide resolved
@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 20, 2023

PR validation failed because no disk space on agent, try close and open PR.

@liuh-80 liuh-80 closed this Jul 20, 2023
@liuh-80 liuh-80 reopened this Jul 20, 2023
@liuh-80 liuh-80 merged commit fb338d5 into sonic-net:master Jul 21, 2023
4 checks passed
@liuh-80 liuh-80 deleted the dev/liuh/cherry-pick-zmq branch July 21, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants