Add SaveOnSet #108
Merged
Add SaveOnSet #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomek-US
reviewed
May 15, 2023
anand-kumar-subramanian
requested changes
Jun 6, 2023
anand-kumar-subramanian
previously approved these changes
Feb 14, 2024
anand-kumar-subramanian
approved these changes
May 13, 2024
|
Sorry wrong link to HLD. it is here sonic-net/SONiC#1297 |
sachinholla
reviewed
May 16, 2024
| @@ -503,6 +530,7 @@ func (s *Server) Set(ctx context.Context, req *gnmipb.SetRequest) (*gnmipb.SetRe | |||
| common_utils.IncCounter(common_utils.GNMI_SET_FAIL) | |||
| } | |||
|
|
|||
| s.SaveStartupConfig() | |||
There was a problem hiding this comment.
No locks in both Set() and SaveOnSetEnabled(). Is it safe to allow parallel db writes and config saves?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Enable save-on-set for gnmi. Creates a configDB backup to disk after eat gnmi.Set if enabled.
How I did it
Add a function pointer that allows the entire feature to be enabled by command line argument. If enabled, a call to sonic-services-client sends a message on the DBUS to the sonic host service modules.
HLD here
sonic-net/SONiC#1239
sonic-buildimage PR here
sonic-net/sonic-buildimage#18481