Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonic-sairedis submodule #9924

Closed

Conversation

tbgowda
Copy link
Contributor

@tbgowda tbgowda commented Feb 6, 2022

Why I did it

Bringing in changes to support SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL

Bringing in the following changes:

Submodule src/sonic-sairedis d5866a3..f484cf9:

Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (sonic-net/sonic-sairedis#975)
Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (sonic-net/sonic-sairedis#975)
[pipeline] Download swss common artifact in a separated directory (sonic-net/sonic-sairedis#995)
Change sonic-buildimage.vs artifact source from CI build to official build. (sonic-net/sonic-sairedis#992)

How I did it

Please refer to
sonic-net/sonic-sairedis#975
#9419

How to verify it

Please refer to
sonic-net/sonic-sairedis#975
#9419

Which release branch to backport (provide reason below if selected)

Ideally it is preferred we back port to all branches where fast-reboot is supported. However, 202012 seems like a critical release train.

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL in case of fast-reboot

A picture of a cute animal (not mandatory but encouraged)

@yxieca
Copy link
Contributor

yxieca commented Feb 14, 2022

@tbgowda please list the commits that are included by this submodule head change

@tbgowda
Copy link
Contributor Author

tbgowda commented Feb 16, 2022

@yxieca , I have updated the description with the commits. Please let me know if anything more needs to be updated.

@tbgowda
Copy link
Contributor Author

tbgowda commented Feb 16, 2022

I am little confused here, sonic-net/sonic-sairedis#975 was committed to sonic-sairedis master branch. But we need that commit in 202012 as well.

Should there be a double commit of sonic-net/sonic-sairedis#975 to sonic-sairedis 202012 branch and a new PR generated for sonic-buildimage 202012 branch to update the sonic-sairedis submodule?

@sachinv-msft
Copy link

@yxieca can we add the request for 202012 branch!

@prsunny
Copy link
Contributor

prsunny commented Mar 2, 2022

@yxieca can we add the request for 202012 branch!

@sachinv-msft , submodule-update must be raised separately to corresponding branch

@msosyak
Copy link
Contributor

msosyak commented Mar 15, 2022

This PR looks outdated. The actual sairedis refpoint is b9337(Feb 22, 2022) and f484cf9 is present in history.

@lguohan lguohan closed this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants