[dhcp_relay] Fix sendto: invalid destination address error #9143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiarcot895
approved these changes
Nov 2, 2021
|
why we could not catch this issue in the sonic-mgmt test? |
|
@lguohan There were 4 server addresses, and only one was affected, so packets were still successfully relayed to the other three destination addresses. Sonic-mgmt only checks if >=1 expected packet is received. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Not all relay forward packets are sent to desired dhcpv6_servers.
Sendto error: invalid destination address
How I did it
Memory gets deallocated at end of loop_relay, need to allocate object on the heap.
How to verify it
Build dhcp6relay debian package and run dhcpv6 relay tests
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)