Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACACS+] Add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting. #9029

Merged
merged 7 commits into from
Nov 5, 2021

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Oct 21, 2021

This pull request add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting.

Why I did it

Support TACACS per-command authorization&accounting.

How I did it

Change ConfigDB schema and HostCfg enforcer.
Add UT to cover changed code.

How to verify it

Build following project and pass all UTs:
make target/python-wheels/sonic_host_services-1.0-py3-none-any.whl

Which release branch to backport (provide reason below if selected)

N/A

Description for the changelog

Add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting.

A picture of a cute animal (not mandatory but encouraged)

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Oct 22, 2021

Your PR title is truncated and you deleted the remaining part.


In reply to: 949460053

@liuh-80 liuh-80 marked this pull request as ready for review October 28, 2021 02:59
@liuh-80 liuh-80 requested a review from lguohan as a code owner October 28, 2021 02:59
@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 28, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@liuh-80
Copy link
Contributor Author

liuh-80 commented Oct 29, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 changed the title [TACACS+] Add Config DB schema and HostCfg Enforcer plugin to support… [TACACS+] Add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting. Nov 5, 2021
@liuh-80
Copy link
Contributor Author

liuh-80 commented Nov 5, 2021

Your PR title is truncated and you deleted the remaining title in PR description.

PR title fixed.

@liuh-80 liuh-80 merged commit a61ffcd into sonic-net:master Nov 5, 2021
qiluo-msft pushed a commit that referenced this pull request Jul 11, 2023
…o support TACACS+ per-command authorization&accounting.(#9029) (#15718)

This pull request add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting.

##### Work item tracking
- Microsoft ADO **(number only)**: 24433713

#### Why I did it
    Support TACACS per-command authorization&accounting.

#### How I did it
    Change ConfigDB schema and HostCfg enforcer.
    Add UT to cover changed code.

#### How to verify it
    Build following project and pass all UTs:
    make target/python-wheels/sonic_host_services-1.0-py3-none-any.whl

#### Which release branch to backport (provide reason below if selected)
    N/A

#### Tested branch (Please provide the tested image version)
Extract tacacs support functions into library, this will share TACACS config file parse code with other project.
Also fix memory leak issue in parse config code.

- [ ]  SONiC.202012-15723.309781-38d8852cd

#### Description for the changelog
    Add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants