[frrcfgd][bgpcfgd] Add portchannel support #8911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
prsunny
reviewed
Oct 7, 2021
| @@ -183,7 +183,10 @@ def __ne__(self, other): | |||
| def __hash__(self): | |||
| return hash((self.af, self.blackhole, self.ip, self.interface, self.distance, self.nh_vrf)) | |||
| def is_zero_ip(self): | |||
| return sum([x for x in socket.inet_pton(self.af, self.ip)]) == 0 | |||
| if self.ip.startswith('PortChannel'): | |||
There was a problem hiding this comment.
Please don't overload this function. You can write a new function as "is_portchannel" and update the caller to treat this valid.
There was a problem hiding this comment.
I wrote a new function and wrapped it in zero_ip() in try-exception because the string is being processed in inet_pton() which throws an exception
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
|
This pull request introduces 2 alerts when merging cdcb9fc into 3426739 - view on LGTM.com new alerts:
|
shi-su
reviewed
Oct 8, 2021
shi-su
reviewed
Oct 8, 2021
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
|
This pull request introduces 2 alerts when merging 4dd4c17 into 3855ce2 - view on LGTM.com new alerts:
|
shi-su
reviewed
Oct 12, 2021
Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
shi-su
approved these changes
Oct 13, 2021
prsunny
approved these changes
Oct 13, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 21, 2021
* To add portchannel support in frrcfgd and bgpcfgd * Update is_zero_ip() to handle portchannel name Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To add portchannel support in frrcfgd and bgpcfgd.
fix #8907
How I did it
Added handling of the portchannel name as an IP address by adding check in is_zero_ip() to prevent parsing portchannel name with socket.inet_pton().
How to verify it