-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile for fast-reboot performance #8897
Merged
liat-grozovik
merged 2 commits into
sonic-net:master
from
shlomibitton:shlomi_sn3800_msft_sku_fix
Nov 1, 2021
Merged
[Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile for fast-reboot performance #8897
liat-grozovik
merged 2 commits into
sonic-net:master
from
shlomibitton:shlomi_sn3800_msft_sku_fix
Nov 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
liat-grozovik
changed the title
[SAI profile] Fix split configuration for Mellanox SN3800-D112C8 SKU
[Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile
Oct 17, 2021
dgsudharsan
approved these changes
Oct 19, 2021
dgsudharsan
suggested changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please correct the alignment?
@dgsudharsan Done. |
dgsudharsan
approved these changes
Oct 25, 2021
shlomibitton
changed the title
[Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile
[Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile for fast-reboot performance
Oct 31, 2021
liat-grozovik
approved these changes
Nov 1, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 5, 2021
… profile for fast-reboot performance (#8897) - Why I did it Wrong SKU configuration will lead to longer init flow. This will affect fast-reboot feature by increasing the traffic downtime. Since MLNX met the required downtime period with this SKU this bug found with a delay. - How I did it Add the required split labels for ports. - How to verify it Run fast-reboot with this platform using SN3800-D112C8 SKU.
judyjoseph
pushed a commit
that referenced
this pull request
Nov 9, 2021
… profile for fast-reboot performance (#8897) - Why I did it Wrong SKU configuration will lead to longer init flow. This will affect fast-reboot feature by increasing the traffic downtime. Since MLNX met the required downtime period with this SKU this bug found with a delay. - How I did it Add the required split labels for ports. - How to verify it Run fast-reboot with this platform using SN3800-D112C8 SKU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Why I did it
Wrong SKU configuration will lead to longer init flow.
This will affect fast-reboot feature by increasing the traffic downtime.
Since MLNX met the required downtime period with this SKU this bug found with a delay.
How I did it
Add the required split labels for ports.
How to verify it
Run fast-reboot with this platform using SN3800-D112C8 SKU.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)