Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile for fast-reboot performance #8897

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Conversation

shlomibitton
Copy link
Contributor

@shlomibitton shlomibitton commented Oct 3, 2021

Signed-off-by: Shlomi Bitton shlomibi@nvidia.com

Why I did it

Wrong SKU configuration will lead to longer init flow.
This will affect fast-reboot feature by increasing the traffic downtime.
Since MLNX met the required downtime period with this SKU this bug found with a delay.

How I did it

Add the required split labels for ports.

How to verify it

Run fast-reboot with this platform using SN3800-D112C8 SKU.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
@liat-grozovik liat-grozovik changed the title [SAI profile] Fix split configuration for Mellanox SN3800-D112C8 SKU [Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile Oct 17, 2021
Copy link
Collaborator

@dgsudharsan dgsudharsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct the alignment?

@shlomibitton
Copy link
Contributor Author

@dgsudharsan Done.

@shlomibitton shlomibitton changed the title [Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile [Mellanox] Fix split configuration for Mellanox SN3800-D112C8 SKU SAI profile for fast-reboot performance Oct 31, 2021
@liat-grozovik liat-grozovik merged commit ac8fd0d into sonic-net:master Nov 1, 2021
qiluo-msft pushed a commit that referenced this pull request Nov 5, 2021
… profile for fast-reboot performance (#8897)

- Why I did it
Wrong SKU configuration will lead to longer init flow.
This will affect fast-reboot feature by increasing the traffic downtime.
Since MLNX met the required downtime period with this SKU this bug found with a delay.

- How I did it
Add the required split labels for ports.

- How to verify it
Run fast-reboot with this platform using SN3800-D112C8 SKU.
judyjoseph pushed a commit that referenced this pull request Nov 9, 2021
… profile for fast-reboot performance (#8897)

- Why I did it
Wrong SKU configuration will lead to longer init flow.
This will affect fast-reboot feature by increasing the traffic downtime.
Since MLNX met the required downtime period with this SKU this bug found with a delay.

- How I did it
Add the required split labels for ports.

- How to verify it
Run fast-reboot with this platform using SN3800-D112C8 SKU.
@shlomibitton shlomibitton deleted the shlomi_sn3800_msft_sku_fix branch March 15, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants