Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-switching silicon Common config for Broadcom Supported Platforms #7493

Merged
merged 9 commits into from
Jun 4, 2021
Merged

Per-switching silicon Common config for Broadcom Supported Platforms #7493

merged 9 commits into from
Jun 4, 2021

Conversation

geans-pin
Copy link
Contributor

@geans-pin geans-pin commented Apr 30, 2021 •
edited
Loading

Additional commit along with PR#693 and HLD PR#699

@lguohan
Copy link
Collaborator

lguohan commented May 2, 2021

can you check the url for 693, it does not seem relavant.

@lguohan lguohan requested a review from gechiang May 2, 2021 16:47
@geans-pin
Copy link
Contributor Author

can you check the url for 693, it does not seem relavant.

Sorry, I correct the typo and point to the right PR. Pls check again

@lguohan
Copy link
Collaborator

lguohan commented May 7, 2021

@gechiang , can you help to review?

@gechiang
Copy link
Collaborator

gechiang commented Jun 1, 2021

@geans-pin For the 6 common config.bcm file sock properties, can you detailed what each SOC property is for and whether these ones belong to the set where you do not expect any vendor from making changes from their specific SKU's config.bcm file?

@geans-pin
Copy link
Contributor Author

@geans-pin For the 6 common config.bcm file sock properties, can you detailed what each SOC property is for and whether these ones belong to the set where you do not expect any vendor from making changes from their specific SKU's config.bcm file?

Per HLD reply, we will provide the detail for each SOC property in an enhancement PR after this baseline PR is merged.
So far we are collecting the information from the BRCM Team ...

Geans

@geans-pin
Copy link
Contributor Author

/Azurepipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 7493 in repo Azure/sonic-buildimage

@geans-pin
Copy link
Contributor Author

Gechiang,

Pls check the property readme I uploaded.

Geans

@gechiang gechiang merged commit 5366333 into sonic-net:master Jun 4, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@geans-pin
Per-switching silicon Common config for Broadcom Supported Platforms (s…
8eb5bf0 
…onic-net#7493)

* Per-switching silicon Common config for Broadcom Supported Platforms

* Per-switching silicon Common config for Broadcom Supported Platforms

* Per-switching silicon Common config for Broadcom Supported Platforms

* Remove property readme

* Add common config readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gechiang gechiang gechiang approved these changes

@jleveque jleveque Awaiting requested review from jleveque

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geans-pin @lguohan @gechiang