-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[201811] Fix swsssdk build by installing redis explicitly #7414
Conversation
Commenter does not have sufficient privileges for PR 7414 in repo Azure/sonic-buildimage |
can you add description? why do you do it? |
Updated the description Guohan. As of now, there are two solutions as mentioned above.
|
@yxieca , can you check? |
@samaity my internal 201811 build doesn't seem to need this change. |
|
@samaity I guess the problem start to happen on public build too: https://sonic-jenkins.westus2.cloudapp.azure.com/job/broadcom/job/buildimage-brcm-201811/90/console In that case, I think we should pin the version to 20.3.3 to match with image build change a5b9abc |
BTW: even with this change, we would hit other issues like the one from 201911: |
#7459 will address the snmp docker build issue. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Sangita Maity samaity@linkedin.com
Why I did it
for 201811 build image, swsssdk wheel package is not getting build due to
redis==2.10.6
requirement issue. Notied that after upgrading pip to 20.3.3, we are experiencling this issue.the issue
So, what I have understood till now, if pip v20.3.3 is able to produce a wheel that is not installable because it raises pip._vendor.packaging.version.InvalidVersion or some error like that (resource- > pypa/pip#9206), it just raises an exception when building the wheel.
SO, this issue occurs when we pinned down pip to 20.3.3 in short.
As of now, there are two solutions mentioned below.
How I did it
How to verify it
Build got successful.