BRCM SAI 4.3.0.10-4 Fix _brcm_sai_indexed_data_get () with unexpected queue causing _brcm_sai_switch_assert () after warm reboot #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… queue causing _brcm_sai_switch_assert () after warm reboot
lguohan
approved these changes
Feb 3, 2021
deran1980
pushed a commit
to deran1980/sonic-buildimage
that referenced
this pull request
Feb 4, 2021
… queue causing _brcm_sai_switch_assert () after warm reboot (sonic-net#6664)
daall
pushed a commit
that referenced
this pull request
Feb 5, 2021
… queue causing _brcm_sai_switch_assert () after warm reboot (#6664)
daall
pushed a commit
that referenced
this pull request
Feb 6, 2021
… queue causing _brcm_sai_switch_assert () after warm reboot (#6664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Porting the same workaround frix from BRCM SAI 4.2.1.5-9 to SAI 4.3.0.10-4 to address the same WARM Reboot SYNCd crash issue.
See (#6374)
This is a known case filed with BRCM (CS00011729363) during SAI 4.2 time and the same fix was missing in 4.3 as well. We are porting this change in master branch that has moved on to SAI 4.3.0.10 release so that it will allow further feature validation/testing especially in the warm reboot area.
Once an official fix is provided by BRCM, we will then remove this in house fix and apply the official fix.
(Update 2/8/21: The workaround was blessed by BRCM so the workaround is official fix).
This PR fixes (#6655)
- How to verify it
Just perform warm reboot with any master code prior to this PR you should see SYNCd crash issue with something as the following in the syslog:
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
BRCM SAI 4.3.0.10-4 Fix _brcm_sai_indexed_data_get () with unexpected queue causing _brcm_sai_switch_assert () after warm reboot