Fix bgp crash after BGP allow list configuration is added #6088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix the bgp crash issue after BGP allow list configuration is added. If load BGP allow list configuration, the
bgp
service will crash:- Why I did it
This change is to fix the bgp crash issue after BGP allow list configuration is loaded.
The issue was a typo introduced in #6006. In that change, the BGP allow list
configuration manager was updated to use a method of common ConfigMgr
for restarting peer groups. However, the method name 'restart_peers' was
used instead of the correct 'restart_peer_groups'.
- How I did it
This change updated the managers_allow_list.py to use correct method
'restart_peer_groups' instead of 'restart_peers' for restarting peer groups.
- How to verify it
/usr/local/lib/python3.7/dist-packages/bgpcfgd/managers_allow_list.py
with the updated version in bgp docker.sudo systemctl restart bgp
.- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)