Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista] Rename chip in sensors.conf for 7170 platform #6026

Merged

Conversation

NazarTkachuk
Copy link
Contributor

@NazarTkachuk NazarTkachuk commented Nov 24, 2020

Rename chip name dps1900-i2c-X-58 to pmbus-i2c-X-58 in sensors.conf for Arista 7170 due to latest updates for Arista driver submodules #5686. After these updates adapter dps1900 was renamed and sensors.conf file is not applied properly. Issue was observed started from BFN SONiC image 16. See logs below
SONiC 13

admin@sonic:~$ sensors -A -u
dps1900-i2c-7-58
vin:
in1_input: 0.000
in1_alarm: 0.000
vout1:
in2_input: 0.000
in2_lcrit: 10.750
in2_crit: 14.250
in2_lcrit_alarm: 0.000
in2_crit_alarm: 0.000
fan1:
fan1_input: 7888.000
fan1_alarm: 0.000
fan1_fault: 0.000
PSU2 primary hotspot temp:
temp1_input: 0.000
temp1_alarm: 0.000
PSU2 inlet temp:
temp2_input: 0.000
temp2_alarm: 0.000
iin:
curr1_input: 0.000
curr1_max: 10.000
curr1_max_alarm: 0.000
iout1:
curr2_input: 0.000
curr2_max: 71.875
curr2_crit: 74.375
curr2_max_alarm: 0.000
curr2_crit_alarm: 0.000

SONiC 16

admin@sonic:~$ sensors -A -u
pmbus-i2c-6-58
vin:
in1_input: 225.750
in1_alarm: 0.000
vout1:
in2_input: 12.005
in2_lcrit: 10.750
in2_crit: 14.250
in2_lcrit_alarm: 0.000
in2_crit_alarm: 0.000
fan1:
fan1_input: 7760.000
fan1_alarm: 0.000
fan1_fault: 0.000
temp1:
temp1_input: 28.000
temp1_alarm: 0.000
temp2:
temp2_input: 15.000
temp2_alarm: 0.000
temp3:
temp3_input: 32.000
temp3_alarm: 0.000
pin:
power1_input: 237.000
power1_alarm: 0.000
pout1:
power2_input: 219.250
pout2:
power3_input: 219.250
iin:
curr1_input: 1.064
curr1_max: 10.000
curr1_max_alarm: 0.000
iout1:
curr2_input: 18.250
curr2_max: 71.875
curr2_crit: 74.375
curr2_max_alarm: 0.000
curr2_crit_alarm: 0.000
iout2:
curr3_input: 18.250
curr3_crit: 74.375
curr3_crit_alarm: 0.000

Note: Issue is observed only on SONiC master and CT sensors is failed on SONiC master

Signed-off-by: Nazar Tkachuk nazarx.tkachuk@intel.com

- Why I did it
CT sensors is failed on platform x86_64-arista_7170_64c

- How I did it

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…or Arista 7170

Signed-off-by: Nazar Tkachuk <nazarx.tkachuk@intel.com>
@NazarTkachuk
Copy link
Contributor Author

Pls, review @lguohan @Staphylo

Copy link
Collaborator

@Staphylo Staphylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@NazarTkachuk
Copy link
Contributor Author

retest vs please

@SavchukRomanLv
Copy link
Contributor

@jleveque can you please take a look?

@jleveque jleveque changed the title Rename chip name dps1900-i2c-X-58 to pmbus-i2c-X-58 in sensors.conf [Arista] Rename chip in sensors.conf for 7170 platform Dec 1, 2020
@jleveque jleveque merged commit be145b6 into sonic-net:master Dec 1, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Rename chip name dps1900-i2c-X-58 to pmbus-i2c-X-58 in sensors.conf for Arista 7170 due to latest updates for Arista driver submodules sonic-net#5686. After these updates adapter dps1900 was renamed and sensors.conf file is not applied properly. Issue was observed started from BFN SONiC image 16.

Signed-off-by: Nazar Tkachuk <nazarx.tkachuk@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants