Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[as7326-56x]Fix thermal plan when fan insert back #5412

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jostar-yang
Copy link
Contributor

- Why I did it
When plug out one fan, fan speed will set to 100%. But plug in back fan, speed still is 100%.
- How I did it
Modify code. When fan insert back, fan speed should be depend on thermal plan.
- How to verify it
Run thermal code, plug out fan. And then insert back fan. Check fan speed.
root : DEBUG new_perc=38
root : DEBUG temp2=lm75_49=25500,temp4=lm_4b=24500, temp_get=25000, ori_state=1
(Plug out one fan)

root : DEBUG new_perc=38
root : DEBUG fan_4 fail, set new_perc to 100
root : DEBUG fan_policy_state=3
root : WARNING fan_policy_state is LEVEL_FAN_MAX

...............................
(Plug in back the fan)
root : DEBUG temp=24750
root : DEBUG temp=24750 >= policy[0][0]=0, temp=24750 < policy[0][1]=39000
root : DEBUG fan_state=1
root : DEBUG temp2=lm75_49=25000,temp4=lm_4b=24500, temp_get=24750, ori_state=1
root : DEBUG new_perc=38
root : INFO Set fan speed from 100 to 38
root : DEBUG fan_dir=0, ori_perc=38
................
- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@jostar-yang jostar-yang changed the title [as7326-54x]Fix thermal plan when fan insert back [as7326-56x]Fix thermal plan when fan insert back Sep 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request introduces 1 alert and fixes 13 when merging 2096eaf into 3987cbd - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 6 for Unused import
  • 4 for Unused local variable
  • 2 for Use of 'global' at module level
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request introduces 1 alert and fixes 13 when merging 4676d6d into 3987cbd - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 6 for Unused import
  • 4 for Unused local variable
  • 2 for Use of 'global' at module level
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request fixes 9 alerts when merging 6cf8f1f into 3987cbd - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 4 for Unused import
  • 1 for Unreachable code

jleveque
jleveque previously approved these changes Sep 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2021

This pull request fixes 5 alerts when merging 6e5a54e into 7df4c0a - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2022

This pull request fixes 5 alerts when merging ac6e4e9 into f136c53 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Mar 22, 2022

This pull request introduces 2 alerts and fixes 3 when merging b7c12d3 into 90416b5 - view on LGTM.com

new alerts:

  • 2 for Unused local variable

fixed alerts:

  • 2 for Unused local variable
  • 1 for Unreachable code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants