[slave.mk]: Adding support to specify debs dependencies for python-de… #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs package. Adding support to specify build time DEB package dependencies for python-debs package. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
praveen-li
commented
Jun 25, 2020
|
Kindly review this one as well. Thx a lot. |
jleveque
approved these changes
Jun 26, 2020
pjaipakdee19
pushed a commit
to pjaipakdee19/sonic-buildimage
that referenced
this pull request
Jul 7, 2020
…bs package. (sonic-net#4849) **- How I did it** added below line: $$(addsuffix -install,$$(addprefix $(DEBS_PATH)/,$$($$*_DEBS_DEPENDS))) \ **- How to verify it** Added below dependencies in sonic-utils ``` SONIC_UTILS = python-sonic-utilities_1.2-1_all.deb $(SONIC_UTILS)_SRC_PATH = $(SRC_PATH)/sonic-utilities $(SONIC_UTILS)_DEBS_DEPENDS = $(LIBYANG) $(LIBYANG_CPP) $(LIBYANG_PY2) \ <<<<<<<<<<< $(LIBYANG_PY3) $(SONIC_UTILS)_WHEEL_DEPENDS = $(SONIC_CONFIG_ENGINE) $(SONIC_YANG_MGMT_PY) SONIC_PYTHON_STDEB_DEBS += $(SONIC_UTILS) ``` Build the PKGs successfully. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bs package.
Adding support to specify build time DEB package dependencies for python-debs package.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
- Why I did it
Adding support to specify build time DEB package dependencies for python-debs package.
Why it is needed:
To run new tests in sonic_utils, I need to add libyang*.deb as bbuild time dependencies.
- How I did it
$$(addsuffix -install,$$ (addprefix $(DEBS_PATH)/,$ $($$*_DEBS_DEPENDS))) \
added below line:
- How to verify it
Added below dependencies in sonic-utils
Build the PKGs successfully.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)