Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha and ECN settings change for Th #4564

Merged
merged 1 commit into from
May 9, 2020

Conversation

neethajohn
Copy link
Contributor

Signed-off-by: Neetha John nejo@microsoft.com

Dynamic threshold setting changed to 0 and WRED profile green min threshold set to 250000 for Tomahawk devices

- How I did it
Changed the dynamic threshold settings in pg_profile_lookup.ini
Added a macro for WRED profiles in qos.json.j2 for Tomahawk devices
Necessary changes made in qos.config.j2 to use the macro if present

- How to verify it
Replaced pg_profile_lookup.ini and qos.json.j2 for the corresponding template on the device.
Replaced the qos.config.j2 template with the modified one in /usr/share/sonic/templates
Did a 'config load_minigraph' followed by 'config save'
Verified that pg_lossless profiles had 'dynamic threshold' set to 0 and AZURE_LOSSLESS wred profile had the green min threshold set to 250000

Signed-off-by: Neetha John <nejo@microsoft.com>
@neethajohn
Copy link
Contributor Author

retest broadcom please

@yxieca
Copy link
Contributor

yxieca commented May 9, 2020

retest broadcom please

@yxieca
Copy link
Contributor

yxieca commented May 9, 2020

retest vsimage please

@lguohan lguohan merged commit 286aa35 into sonic-net:master May 9, 2020
yxieca pushed a commit that referenced this pull request May 9, 2020
Dynamic threshold setting changed to 0 and WRED profile green min threshold set to 250000 for Tomahawk devices

Changed the dynamic threshold settings in pg_profile_lookup.ini
Added a macro for WRED profiles in qos.json.j2 for Tomahawk devices
Necessary changes made in qos.config.j2 to use the macro if present

Signed-off-by: Neetha John <nejo@microsoft.com>
rlhui pushed a commit that referenced this pull request May 10, 2020
Dynamic threshold setting changed to 0 and WRED profile green min threshold set to 250000 for Tomahawk devices

Changed the dynamic threshold settings in pg_profile_lookup.ini
Added a macro for WRED profiles in qos.json.j2 for Tomahawk devices
Necessary changes made in qos.config.j2 to use the macro if present

Signed-off-by: Neetha John <nejo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants