Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert docker-snmp-sv2 to buster #4529

Merged
merged 9 commits into from
May 14, 2020
Merged

Convert docker-snmp-sv2 to buster #4529

merged 9 commits into from
May 14, 2020

Commits on May 14, 2020

  1. Fix libsnmp-base compilation failure 

    libtool: link: gcc -DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -g -O2 -fdebug-prefix-map=/sonic/src/snmpd/net-snmp-5.7.3+dfsg=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -DNETSNMP_USE_INLINE -Ulinux -Dlinux=linux -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/lib/x86_64-linux-gnu/perl/5.28/CORE -o .libs/snmptrapd .libs/snmptrapd.o -specs=/usr/share/dpkg/no-pie-link.specs -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-E  ./.libs/libnetsnmptrapd.so ../agent/.libs/libnetsnmpmibs.so ../agent/.libs/libnetsnmpagent.so ../snmplib/.libs/libnetsnmp.so -L/usr/lib/x86_64-linux-gnu/ -lmariadb -lnl-3 -lm -lwrap
/usr/bin/ld: ./.libs/libnetsnmptrapd.so: undefined reference to `load_defaults'
/usr/bin/ld: ./.libs/libnetsnmptrapd.so: undefined reference to `my_init'
collect2: error: ld returned 1 exit status
make[5]: *** [Makefile:297: snmptrapd] Error 1
make[5]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg/apps'
make[4]: *** [Makefile:657: subdirs] Error 1
make[4]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg'
dh_auto_build: make -j1 returned exit code 2
make[3]: *** [debian/rules:65: override_dh_auto_build] Error 2
make[3]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg'
make[2]: *** [debian/rules:41: binary] Error 2
make[2]: Leaving directory '/sonic/src/snmpd/net-snmp-5.7.3+dfsg'
make[1]: *** [Makefile:19: /sonic/target/debs/buster/libsnmp-base_5.7.3+dfsg-1.5_all.deb] Error 2

Fix: The definitions of load_defaults and my_init don't exist and hence
commenting out their use

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
    @joyas-joseph @lguohan
    joyas-joseph authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    7dcba0b View commit details
    Browse the repository at this point in the history

  2. Convert docker-snmp-sv2 to buster 

    use python3 provided by buster

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
    @joyas-joseph @lguohan
    joyas-joseph authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    a63d6e8 View commit details
    Browse the repository at this point in the history

  3. Define install_python3_wheels 

    Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
    @joyas-joseph @lguohan
    joyas-joseph authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    51cc3e7 View commit details
    Browse the repository at this point in the history

  4. Address review comments 

    Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
    @joyas-joseph @lguohan
    joyas-joseph authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    6d294b3 View commit details
    Browse the repository at this point in the history

  5. Address review comments 

    - Remove python3-dev (actual installed package) instead of libpython3-dev

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
    @joyas-joseph @lguohan
    joyas-joseph authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    6850da4 View commit details
    Browse the repository at this point in the history

  6. Advance snmpagent submodule 

    Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
    @joyas-joseph @lguohan
    joyas-joseph authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    181b8ed View commit details
    Browse the repository at this point in the history

  7. Bump net-snmp to the Buster version

    @qiluo-msft @lguohan
    qiluo-msft authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    778d995 View commit details
    Browse the repository at this point in the history

  8. Revert "Fix libsnmp-base compilation failure" 

    This reverts commit d808ebe.
    @qiluo-msft @lguohan
    qiluo-msft authored and lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    6f605c3 View commit details
    Browse the repository at this point in the history

  9. use azure storage url 

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    @lguohan
    lguohan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    61e3c6a View commit details
    Browse the repository at this point in the history