Multi DB with namespace support, Introducing the database_global.json… #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Apr 24, 2020
qiluo-msft
reviewed
Apr 24, 2020
|
Retest this please |
qiluo-msft
reviewed
Apr 27, 2020
qiluo-msft
reviewed
Apr 27, 2020
qiluo-msft
reviewed
Apr 27, 2020
qiluo-msft
reviewed
Apr 27, 2020
qiluo-msft
reviewed
Apr 27, 2020
qiluo-msft
reviewed
Apr 27, 2020
src/sonic-config-engine/sonic-cfggen
Outdated
| @@ -211,6 +211,7 @@ def main(): | |||
| group.add_argument("--preset", help="generate sample configuration from a preset template", choices=get_available_config()) | |||
| group = parser.add_mutually_exclusive_group() | |||
| group.add_argument("-K", "--key", help="Lookup for a specific key") | |||
| parser.add_argument("-n", "--namespace", help="Namespace string to use asic0/asic1.../asicn", default=None) | |||
There was a problem hiding this comment.
Could you also explain the ignore behavior, and also the -namespace='' behavior in usage?
There was a problem hiding this comment.
|
retest vsimage please |
|
retest vs please |
1 similar comment
|
retest vs please |
|
retest vsimage please |
|
retest vsimage please |
|
retest broadcom please |
|
retest this please |
|
retest broadcom please |
lguohan
reviewed
May 5, 2020
qiluo-msft
reviewed
May 5, 2020
qiluo-msft
reviewed
May 5, 2020
|
pushed multiple fixes as a single commit. |
…rsing minigraph and multi DB access.
…to database_config.json file earlier.
We use the database_config.json.j2 file to generate database_config.json files dynamically.
… this we wait till the PONG response is received when redis server is up.
|
Rebased the sonic-buildimage to get the PR (#4541) which has the updated logic with sonic-db-cli PING tests to check redis server. |
qiluo-msft
previously approved these changes
May 7, 2020
lguohan
previously approved these changes
May 7, 2020
…install of j2cli in docker-base-buster.
qiluo-msft
approved these changes
May 7, 2020
|
retest this please |
|
retest broadcom please |
dzhangalibaba
approved these changes
May 7, 2020
|
LGTM now |
|
retest broadcom please |
1 similar comment
|
retest broadcom please |
lguohan
approved these changes
May 9, 2020
|
@judyjoseph, there's conflict cherry-pick to 201911 branch. Please raise a separate PR for 201911 branch. Thanks. |
abdosi
pushed a commit
that referenced
this pull request
May 10, 2020
#4477) * Multi DB with namespace support, Introducing the database_global.json file for supporting accessing DB's in other namespaces for service running in linux host * Updates based on comments * Adding the j2 templates for database_config and database_global files. * Updating to retrieve the redis DIR's to be mounted from database_global.json file. * Additional check to see if asic.conf file exists before sourcing it. * Updates based on PR comments discussion. * Review comments update * Updates to the argument "-n" for namespace used in both context of parsing minigraph and multi DB access. * Update with the attribute "persistence_for_warm_boot" that was added to database_config.json file earlier. * Removing the database_config.json file to avioid confusion in future. We use the database_config.json.j2 file to generate database_config.json files dynamically. * Update the comments for sudo usage in docker_image_ctrl.j2 * Update with the new logic in PING PONG tests using sonic-db-cli. With this we wait till the PONG response is received when redis server is up. * Similar changes in swss and syncd scripts for the PING tests with sonic-db-cli * Updated with a missing , in the database_config.json.j2 file, Do pip install of j2cli in docker-base-buster.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To support applications running in the linux host to be able to connect to databases in the namespaces. This uses the changes done to python modules via sonic-net/sonic-py-swsssdk@b9cee36
- How I did it
The changes includes the following
- How to verify it
Verified by booting up on the multi-asic platform and single asic platform.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)