Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sairedis] update submodule for sairedis #3984

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

dzhangalibaba
Copy link
Collaborator

update multiDB changes in sairedis, including:

@kcudnik please help check if it is safe to update submodule including all the sairedis related changes before my multiDB changes, is there any dependency? On local, I saw all the vs tests passed.

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

@dzhangalibaba
Copy link
Collaborator Author

@kcudnik please help check if it is safe to update submodule including all the sairedis related changes before my multiDB changes, is there any dependency? On local, I saw all the vs tests passed.

@kcudnik
Copy link
Contributor

kcudnik commented Jan 7, 2020

Not sure why vs failed, i dont see clear indication of issues with pointer, errors are related to snmp, i will request rebuild to see if it passes

@kcudnik
Copy link
Contributor

kcudnik commented Jan 7, 2020

retest this please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

1 similar comment
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@kcudnik
Copy link
Contributor

kcudnik commented Jan 8, 2020

fails every time on

  snmp_facts = lhost.snmp_facts(host=hostip, version="v2c", community=creds["snmp_rocommunity"])['ansible_facts']

E KeyError: 'ansible_facts'

probably this is indirect error related to changes in sairedis :/

@dzhangalibaba
Copy link
Collaborator Author

fails every time on

  snmp_facts = lhost.snmp_facts(host=hostip, version="v2c", community=creds["snmp_rocommunity"])['ansible_facts']

E KeyError: 'ansible_facts'

probably this is indirect error related to changes in sairedis :/

But if you look at other PRs, they all failed here

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

1 similar comment
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@kcudnik
Copy link
Contributor

kcudnik commented Jan 9, 2020

ahh, so if other failed then seems like this testbed is unstable or some other issue

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@kcudnik
Copy link
Contributor

kcudnik commented Jan 10, 2020

build system must be fixed instead of getting lucky on build

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

1 similar comment
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

@kcudnik after the vs image build system fix, this update passed

@lguohan lguohan merged commit 8320267 into sonic-net:master Jan 22, 2020
@dzhangalibaba dzhangalibaba deleted the subsairedis branch February 20, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants