[services] Remove explicit dependencies from dhcp_relay service file, control in swss.sh #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… control in swss.sh
|
Retest vsimage please |
1 similar comment
|
Retest vsimage please |
yxieca
approved these changes
Nov 27, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
… control in swss.sh (sonic-net#3823)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove swss and teamd services from both the
Requires=andWantedBy=fields of the dhcp_relay service file, and instead control the dhcp_relay service from the swss.sh script along with the teamd and radv services.Removing the services from
Requires=field will prevent dhcp_relay from automatically starting teamd when it is started (in case it gets started while teamd is supposed to be shut down), and removing the services from theWantedBy=field will prevent dhcp_relay getting started by systemd if swss or teamd get started. Instead, dhcp_relay will only be started by the swss.sh script in the proper order, ensuring that teamd is always started before dhcp_relay.