[telemetry.sh] Fix string null check with special characters by adding quotes #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hui-ma
approved these changes
Nov 23, 2019
pra-moh
changed the title
pra-moh
changed the title
jleveque
suggested changes
Nov 23, 2019
Co-Authored-By: Joe LeVeque <jleveque@users.noreply.github.com>
Co-Authored-By: Joe LeVeque <jleveque@users.noreply.github.com>
jleveque
approved these changes
Nov 23, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
…g quotes (sonic-net#3810) * adding quotes for string comparison with special characters * Update dockers/docker-sonic-telemetry/telemetry.sh Co-Authored-By: Joe LeVeque <jleveque@users.noreply.github.com> * Update dockers/docker-sonic-telemetry/telemetry.sh Co-Authored-By: Joe LeVeque <jleveque@users.noreply.github.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
…g quotes (sonic-net#3810) Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> * adding quotes for string comparison with special characters * Update dockers/docker-sonic-telemetry/telemetry.sh Co-Authored-By: Joe LeVeque <jleveque@users.noreply.github.com> * Update dockers/docker-sonic-telemetry/telemetry.sh Co-Authored-By: Joe LeVeque <jleveque@users.noreply.github.com> RB=2370687 G=lnos-reviewers R=pchaudha,pmao,vapatil,zxu A=pmao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Adding quotes in string null check as it contains complete cert key and path. The corresponding string generated contains special characters
- How I did it
Verified on device
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)