[router-advertiser] Add templated script to wait for pertinent interfaces to be ready before starting radvd #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces to be ready before starting radvd
|
can you describe the problem that this pr solves? |
|
@lguohan: Added details to PR description. |
lguohan
approved these changes
Mar 2, 2019
|
Made to 201811 branch on 3/6/2019 |
yxieca
added a commit
that referenced
this pull request
Mar 7, 2019
…aces to be ready before starting radvd (#2558)
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…aces to be ready before starting radvd (sonic-net#2558)
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…aces to be ready before starting radvd (sonic-net#2558)
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…aces to be ready before starting radvd (sonic-net#2558)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wait_for_intf.sh.j2 template which, once generated, will create a script which will cause the container to wait for all VLAN interfaces to be ready before starting the radvd process.
This ensures that all interfaces which radvd needs to bind to to send router advertisements on are fully created and up before binding to them. It doesn't appear that this poses a problem for radvd as it does for dhcrelay (it's possible that radvd will attempt to rebind, whereas dhcrelay does not. I haven't examined the code), however I am applying the same mechanism to wait in this container as well just to ensure the radvd daemon is started after the pertinent interfaces are created and up.