Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bde driver] black list linux_kernel_bde driver #2284

Merged
merged 1 commit into from
Nov 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions files/build_templates/sonic_debian_extension.j2
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ sudo cp $IMAGE_CONFIGS/environment/motd $FILESYSTEM_ROOT/etc/

# Create all needed directories
sudo mkdir -p $FILESYSTEM_ROOT/etc/sonic/
sudo mkdir -p $FILESYSTEM_ROOT/etc/modprobe.d/
sudo mkdir -p $FILESYSTEM_ROOT/var/cache/sonic/
sudo mkdir -p $FILESYSTEM_ROOT_USR_SHARE_SONIC_TEMPLATES/

Expand Down Expand Up @@ -261,6 +262,9 @@ fi
## copy platform rc.local
sudo cp $IMAGE_CONFIGS/platform/rc.local $FILESYSTEM_ROOT/etc/

## copy blacklist file
sudo cp $IMAGE_CONFIGS/platform/linux_kernel_bde.conf $FILESYSTEM_ROOT/etc/modprobe.d/
yxieca marked this conversation as resolved.
Show resolved Hide resolved

{% if installer_images.strip() -%}
sudo chroot $FILESYSTEM_ROOT docker info
{% for image in installer_images.strip().split(' ') -%}
Expand Down
1 change: 1 addition & 0 deletions files/image_config/platform/linux_kernel_bde.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
blacklist linux_kernel_bde
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who is trying to load linux_kernel_bde if we are not running sonic service?
backlist does not prevent it from being loaded as a dependency for another kernel module that is not blacklisted, are there any other modules depending on this module that could still start this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is automatically loaded by kernel based on the pcie id. @jipanyang , user-bde and bnet bde are not pci driver, they will not be automatically loaded.