Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine sonic-slave docker image: add entry point #226

Closed
wants to merge 1 commit into from
Closed

Refine sonic-slave docker image: add entry point #226

wants to merge 1 commit into from

Conversation

qiluo-msft
Copy link
Collaborator

No description provided.

marian-pritsak
marian-pritsak reviewed Feb 2, 2017
View reviewed changes
sonic-slave/Dockerfile
@@ -115,3 +115,6 @@ RUN chmod go= /var/$user/.ssh -R
RUN echo "$user ALL=(ALL) NOPASSWD:ALL" >>/etc/sudoers

USER $user

ENTRYPOINT sudo service ssh start && bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have some particular purpose?
Because the actual entry point is usually make command

Copy link
Collaborator Author

@qiluo-msft qiluo-msft Feb 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our use case on https://sonic-jenkins.westus.cloudapp.azure.com/, the 'docker inspect' shows as below.

        "Cmd": [
            "sudo",
            "/usr/sbin/sshd",
            "-D"
        ],
        "Image": "local/sonic-slave",
        "Volumes": null,
        "WorkingDir": "",
        "Entrypoint": null,

It indicates there is no ENTRYPOINT set. And Jenkins run the container with a sshd command. So the overall effect is a sudo process started with PID=1 in the container. This will introduce a PID 1 zombie reaping problem, which finally fails the command 'service docker stop' inside the container.

BTW, there is a good reference table shows the behaviors of ENTRYPOINT and CMD.

@qiluo-msft qiluo-msft closed this Feb 9, 2017
@qiluo-msft qiluo-msft deleted the github_master branch February 9, 2017 21:34
@qiluo-msft qiluo-msft restored the github_master branch February 10, 2017 02:31
@qiluo-msft qiluo-msft reopened this Feb 10, 2017
@stcheng stcheng force-pushed the master branch 2 times, most recently from b9ca7e2 to 42ae02b Compare March 22, 2017 20:29
@qiluo-msft qiluo-msft closed this Jun 19, 2017
@qiluo-msft qiluo-msft deleted the github_master branch June 19, 2017 22:22
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@qiluo-msft
[orchagent]: Implement test_profile_get_next_value() (sonic-net#226)
83e46ba
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
[sairedis]: Perform auto log rotate when record dir gets changed (son…
098732d 
…ic-net#226)
@raphaelt-nvidia raphaelt-nvidia mentioned this pull request Jul 13, 2021
Merged
qiluo-msft pushed a commit that referenced this pull request Jul 13, 2021
@raphaelt-nvidia
[submodule] Update sonic-snmpagent submodule (#7859)
c508a10 
Update sonic-snmpagent submodule to pick up new commits:

21d7d97 2021-07-12 Fix: SonicV2Connector behavior change: get_all will return empty dict if (#226)
0813b42 2021-07-12 Entries under .1.3.6.1.2.1.31.1.1.1.18 OID should return the "description" field of PORT_TABLE entries in APPL_DB or CONFIG_DB. (#224)
7a78703 2021-07-08 Install dotnet core to fix python gcov warning for code covery color bar showing (#215)
e0f36a5 2021-06-30 [multi-asic]: Udpate to use SonicDBConfig from swsscommon (#219)
266bd15 2021-06-10 Restored snmp vlan support per RFC1213 and added the missing support for RFC2863 (#218)
qiluo-msft added a commit that referenced this pull request Jul 14, 2021
@qiluo-msft
[sonic-snmpagent]: Advance submodule (#8176)
30e9c0e 
Includes below commits
```
946e5cf 2021-07-12 | Fix: SonicV2Connector behavior change: get_all will return empty dict if (#226) [Qi Luo]
```
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@raphaelt-nvidia
[submodule] Update sonic-snmpagent submodule (sonic-net#7859)
8000d5c 
Update sonic-snmpagent submodule to pick up new commits:

21d7d97 2021-07-12 Fix: SonicV2Connector behavior change: get_all will return empty dict if (sonic-net#226)
0813b42 2021-07-12 Entries under .1.3.6.1.2.1.31.1.1.1.18 OID should return the "description" field of PORT_TABLE entries in APPL_DB or CONFIG_DB. (sonic-net#224)
7a78703 2021-07-08 Install dotnet core to fix python gcov warning for code covery color bar showing (sonic-net#215)
e0f36a5 2021-06-30 [multi-asic]: Udpate to use SonicDBConfig from swsscommon (sonic-net#219)
266bd15 2021-06-10 Restored snmp vlan support per RFC1213 and added the missing support for RFC2863 (sonic-net#218)
judyjoseph added a commit that referenced this pull request Oct 14, 2021
@judyjoseph
Update sonic-snmpagent submodule
b3c578b 
027dffe Fix: SonicV2Connector behavior change: get_all will return empty dict if (#226)
vdahiya12 added a commit to vdahiya12/sonic-buildimage that referenced this pull request Oct 27, 2021
@vdahiya12
[202012][sonic-platform-common][sonic-platform-daemons] submodule update
f9d7a37 
bf7214c (HEAD -> 202012, origin/202012) [y_cable] add support for manual/standby mode in xcvrd for muxcable; fix download firmware version retrieval logic while download firmware in progress (sonic-net#220)

fc6a41e (HEAD -> 202012, origin/202012) Fix typo in the simulated y_cable driver (sonic-net#226)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12 vdahiya12 mentioned this pull request Oct 27, 2021
Merged
5 tasks
vdahiya12 added a commit that referenced this pull request Oct 27, 2021
@vdahiya12
[202012][sonic-platform-common][sonic-platform-daemons] submodule upd…
933f45e 
…ate (#9081)

bf7214c (HEAD -> 202012, origin/202012) [y_cable] add support for manual/standby mode in xcvrd for muxcable; fix download firmware version retrieval logic while download firmware in progress (#220)

fc6a41e (HEAD -> 202012, origin/202012) Fix typo in the simulated y_cable driver (#226)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@prgeor prgeor mentioned this pull request Nov 14, 2021
Merged
5 tasks
lguohan pushed a commit that referenced this pull request Nov 16, 2021
@prgeor
[submodule]:Update sonic-platform-common submodule (#9256)
c302f49 
c8eceec 400zr initial support (#228)
ef55364 SSD Health: Retrieve SSD health and temperature values from generic SSD info (#229)
26c8346 Fix cmis cable length issue (#225)
671927d Fix typo in the simulated y_cable driver (#226)
51a9aca [sfp-refactor] Add initial support for CMIS in sonic_xcvr (#220)

Signed-off-by: Prince George <prgeor@microsoft.com>
SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Mar 16, 2022
@qiluo-msft
Fix: SonicV2Connector behavior change: get_all will return empty dict…
21d7d97 
… if (sonic-net#226)

the hash does not exist in Redis

- What I did
Fixes sonic-net#8140
ref: swsssdk implementation returns None, and the library will be deprecated
libswsscommon implementation returns empty dict
- How I did it
Relax the condition check to accept both representations
- How to verify it
Unit test
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022
@sharad-brcm
Merge pull request sonic-net#226 from BRCM-SONIC/cyrus-telemetry
8b9dcd0 
Additional watermark counters
@vdahiya12 vdahiya12 mentioned this pull request May 31, 2022
Merged
6 tasks
snider-nokia pushed a commit to snider-nokia/sonic-buildimage that referenced this pull request Apr 6, 2023
@wangxin
Fix typo in the simulated y_cable driver (sonic-net#226)
671927d 
PR sonic-net#221 added retry logic to the simualted y_cable driver and introduced
typos. This change is to fix the typos.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
yxieca pushed a commit that referenced this pull request Dec 18, 2023
@mssonicbld
[submodule] Update submodule linkmgrd to the latest HEAD automatically (
4d5604a 
#17536)

src/linkmgrd

* 6fa4adb - (HEAD -> 202205, origin/202205) [active-standby] Fix `show mux status` inconsistency introduced by orchagent rollback  (#225) (#226) (2 days ago) [Jing Zhang]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marian-pritsak marian-pritsak marian-pritsak left review comments

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiluo-msft @marian-pritsak @stcheng