Fix ecmp hash polarization by enable hash seed/offset config on Broadcom T1 #19454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why I did it To fix ecmp hash polarization issue. How I did it Add sai_hash_seed_config_hash_offset_enable=1 in all config.bcm that Broadcom T1 uses. HardwareSku Force10-S6100-T1 Force10-S6100-ITPAC-T1 Force10-S6100 Celestica-DX010-C32 Arista-7260CX3-C64 Arista-7060CX-32S-Q32 Arista-7060CX-32S-C32-T1 Arista-7060CX-32S-C32 Arista-7050QX32S-Q32 Arista-7050QX-32S-S4Q31 Arista-7050-QX32 Arista-7050-QX-32S Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Gfrom2016
changed the title
8 tasks
|
hi @yxieca @kperumalbfn could you help to review? |
|
hi @Gfrom2016 do we have ADO to track this one? |
|
@Gfrom2016 why are we trying to cherry-pick a change from 202311 to 202405? If the change is needed in both branches but not the master, can you oepn a separate PR for 202405 branch? Thanks! |
|
@Gfrom2016 Why do we need this change in addition to Thanks, |
Sure, will do. |
|
@Gfrom2016 is this change still needed? |
We don't need it anymore, I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To fix ecmp hash polarization issue on 202311 image.
Work item tracking
How I did it
Braodcom's fix for ecmp hash polarization has been included in 10.1.4.0 in #18044
Cherry-pick image fix from #17505
Add sai_hash_seed_config_hash_offset_enable=1 in all config.bcm that Broadcom T1 uses.
How to verify it
Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed.
https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)