Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance IPMI raw cmd and custom pmon object names #19452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance IPMI raw cmd and custom pmon object names #19452

wants to merge 1 commit into from

Conversation

jemifdo
Copy link
Contributor

@jemifdo jemifdo commented Jul 2, 2024

Why I did it

  • IPMI raw commands require some post processing which can be achieved only with method override
  • Custom names for PMON objects is only possible with get_name method override
  • LP mode is attempted to read from EEPROM even when transceiver is not present

How I did it

  • Add below post processing parameters for IPMI raw command
  1. index - byte position
  2. mask - masking the values
  3. offset - to increment or decrement
  4. multiplier - to multiply
  • Specifiy custom names for the PMON objects in pd-plugin.json
  • LPMode is read from the EEPROM of the transceiver only when presence is true

How to verify it

Verified using the Celestica platforms DS2000, DS3000, DS4000

A picture of a cute animal (not mandatory but encouraged)

@jemifdo
Enhance IPMI raw cmd and custom pmon object names
d4c5307 
- Add some post processing parameters for IPMI raw command
- Use custom names for the PMON objects - Fan, Fan drawer, Thermal
- Attempt to get LPMode from the transceiver only when presence is true
@jemifdo jemifdo requested a review from lguohan as a code owner July 2, 2024 10:04
@jemifdo jemifdo marked this pull request as draft July 2, 2024 10:06
@jemifdo jemifdo marked this pull request as ready for review July 2, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jemifdo