fix non canonical format of IPv6 address string in bgpcfgd #19444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPv6 addresses text used in cfgdb may not follow the canonical IPv6 text format. When performing IPv6 addresses equivalent check with string, need to make sure that both of them are in the shortest form defined in rfc 5952
lguohan
reviewed
Jul 2, 2024
| log_warn("IP Address '%s' format is wrong" % (local_addr)) | ||
| return None | ||
| local_addr = str(ip) | ||
|
|
There was a problem hiding this comment.
@chenkelly , can you also add unit test for this code?
There was a problem hiding this comment.
Ok, I'll check and see how to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
IPv6 addresses text used in cfgdb may not follow the canonical IPv6 text format. When performing IPv6 addresses equivalent check with string, need to make sure that both of them are in the shortest form defined in rfc 5952