Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yang model for buffer pool percentage #19358

Merged
merged 4 commits into from
Jul 27, 2024

Conversation

stephenxs
Copy link
Collaborator

Why I did it

Support yang model for percentage field in BUFFER_POOL table.
It is used in dynamic buffer model only and represents the percentage of a buffer pool's size compared to the available memory size

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Unit test and manual test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw ms_conflict

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the yang-model-buffer-precentage branch from fed09c0 to 6e6617e Compare July 2, 2024 05:50
@stephenxs
Copy link
Collaborator Author

Failure

make[2]: Leaving directory '/data/work/1/s/src/sonic-build-hooks'
/data/work/1/s
Unable to find image 'multiarch/qemu-user-static:latest' locally
docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs force-pushed the yang-model-buffer-precentage branch from 6e6617e to 2e3ae0a Compare July 16, 2024 00:40
@stephenxs stephenxs marked this pull request as ready for review July 18, 2024 23:57
@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-builldimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-builldimage

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-builldimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-builldimage

@ganglyu
Copy link
Contributor

ganglyu commented Jul 26, 2024

Do you have any doc for this dynamic buffer mode?

@stephenxs
Copy link
Collaborator Author

Do you have any doc for this dynamic buffer mode?

sonic-net/SONiC#1763

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs requested a review from ganglyu July 26, 2024 00:56
Copy link
Contributor

@wen587 wen587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qiluo-msft qiluo-msft merged commit 11af27d into sonic-net:master Jul 27, 2024
22 checks passed
@stephenxs stephenxs deleted the yang-model-buffer-precentage branch July 27, 2024 02:04
@dprital
Copy link
Collaborator

dprital commented Jul 30, 2024

@bingwang-ms , Can you please cherry pick to 202405 ?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jul 30, 2024
#### Why I did it

Support yang model for `percentage` field in `BUFFER_POOL` table.
It is used in dynamic buffer model only and represents the percentage of a buffer pool's size compared to the available memory size

#### How I did it

#### How to verify it

Unit test and manual test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19740

liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
#### Why I did it

Support yang model for `percentage` field in `BUFFER_POOL` table.
It is used in dynamic buffer model only and represents the percentage of a buffer pool's size compared to the available memory size

#### How I did it

#### How to verify it

Unit test and manual test
@mssonicbld
Copy link
Collaborator

@stephenxs cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#19740

mssonicbld pushed a commit that referenced this pull request Sep 11, 2024
#### Why I did it

Support yang model for `percentage` field in `BUFFER_POOL` table.
It is used in dynamic buffer model only and represents the percentage of a buffer pool's size compared to the available memory size

#### How I did it

#### How to verify it

Unit test and manual test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.