-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Remove pmon delay for certain platforms #19190
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@yxieca can you help to handle ms_conflict and re trigger? |
@stepanblyschak please check #18926 and if this PR need to be updated now with it?cccccbkv |
/azpw ms_conflict |
@vaibhavhd @prgeor Is this a must have for 202405? The change is on all Mellanox platform. |
* [nvidia] Remove pmon delay for certain platforms Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@bingwang-ms , @vaibhavhd , @prgeor - Can you please cherry pick to 202405 ? |
Discussed offline, we are good to cherry-pick it. |
* [nvidia] Remove pmon delay for certain platforms Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Cherry-pick PR to 202405: #19754 |
* [nvidia] Remove pmon delay for certain platforms Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This only works for the Mellanox platform. For other platforms, it would always delay pmon and cause a problem. sonic-net/sonic-platform-daemons#531. |
@chiourung The issue is know and a day one xcvrd issue - #17943. Even if we remove the delay it does not fix the problem but makes it very unlikelly, need to fix a race condition |
Why I did it
For doing fast-reboot with CMIS active modules.
Work item tracking
How I did it
Removed PMON delay for SKUs with support for CMIS active modules
How to verify it
Run fast-reboot test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)