[Mellanox] Verify the value of the control type sysfs before changing it to FW control #19046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are control only if it is not already in firmware control
Junchao-Mellanox
approved these changes
May 23, 2024
tshalvi
changed the title
tshalvi
changed the title
dprital
approved these changes
May 23, 2024
liat-grozovik
approved these changes
May 28, 2024
|
@yxieca , Can you please cherry pick to 202311 ? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 28, 2024
… it to FW control (sonic-net#19046) - Why I did it On Mellanox platforms, changing the control type sysfs value is not supported for ports that are set to firmware control. Therefore, attempting to change this value to firmware control will result in an error log, which we want to avoid. - How I did it I added a check to ensure that the control sysfs value is set to firmware control only if it is not already in firmware control. - How to verify it Ensure that after a warm reboot on the Mellanox platform (an attempt to change the sysfs value from fw_control to fw_control is only applicable in this scenario), the following error does not appear: sxd_kernel: [error] sx_core_set_module_control: Failed control change: module is dependent (FW control).
|
Cherry-pick PR to 202311: #19112 |
mssonicbld
pushed a commit
that referenced
this pull request
May 29, 2024
… it to FW control (#19046) - Why I did it On Mellanox platforms, changing the control type sysfs value is not supported for ports that are set to firmware control. Therefore, attempting to change this value to firmware control will result in an error log, which we want to avoid. - How I did it I added a check to ensure that the control sysfs value is set to firmware control only if it is not already in firmware control. - How to verify it Ensure that after a warm reboot on the Mellanox platform (an attempt to change the sysfs value from fw_control to fw_control is only applicable in this scenario), the following error does not appear: sxd_kernel: [error] sx_core_set_module_control: Failed control change: module is dependent (FW control).
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
|
MSFT ADO: 28219305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
On Mellanox platforms, changing the control type sysfs value is not supported for ports that are set to firmware control. Therefore, attempting to change this value to firmware control will result in an error log, which we want to avoid.
Work item tracking
How I did it
I added a check to ensure that the control sysfs value is set to firmware control only if it is not already in firmware control.
How to verify it
Ensure that after a warm reboot on the Mellanox platform (an attempt to change the sysfs value from fw_control to fw_control is only applicable in this scenario), the following error does not appear:
sxd_kernel: [error] sx_core_set_module_control: Failed control change: module is dependent (FW control).
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)