-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new redis database instance for BMP_STATE_DB. #19016
Open
FengPan-Frank
wants to merge
56
commits into
sonic-net:master
Choose a base branch
from
FengPan-Frank:bmp_db
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
a435bbb
Add new redis database instance for BMP_STATE_DB.
FengPan-Frank f7a26c8
Add new redis database instance for BMP_STATE_DB.
FengPan-Frank 40bb7e3
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 7935008
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 2a0dc1b
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 7755bdb
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank f678bfe
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 1a66414
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank d44fb43
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 6342a85
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 539489e
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank f48a410
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 24e6642
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 986ad60
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank ec885e7
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank c737507
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 3012a60
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank cf40663
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 1f793a7
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 6b7436d
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 53c03e8
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 3ebd78c
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 68d5b7f
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 1d22a4a
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 1b56a0a
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 8554c88
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank acb85f1
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 61b2764
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 62f1548
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 69358fc
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 2475d9c
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 15a9c41
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 82dc66c
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 0f7c8df
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank d7964fb
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank be84bd3
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank ac58616
Merge branch 'master' into bmp_db
FengPan-Frank d506111
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank ccf5149
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 230e16c
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 5720be6
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank cf7bfd8
Merge branch 'master' into bmp_db
FengPan-Frank a2c4355
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 8b740c2
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank fc2f808
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank affa857
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank 63fbc9a
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank fbd913b
Update code
FengPan-Frank c72953b
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank c990844
Merge branch 'sonic-net:master' into bmp_db
FengPan-Frank fdf1908
Fix supervisord.conf issue
FengPan-Frank 345efba
Fix supervisord.conf issue
FengPan-Frank aaee123
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 16c3368
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 61b905f
Merge branch 'bmp_db' of https://github.com/FengPan-Frank/sonic-build…
FengPan-Frank 26b1ae9
Fix supervisord.conf.j2 issue
FengPan-Frank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,11 @@ | |
"port": 6380, | ||
"unix_socket_path": "/var/run/redis/redis_chassis.sock" | ||
} | ||
,"redis_bmp":{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Can we put comma at the end of the previous section? |
||
"hostname" : "127.0.0.1", | ||
"port" : 6400, | ||
"unix_socket_path" : "/var/run/redis/redis_bmp.sock" | ||
} | ||
}, | ||
"DATABASES" : { | ||
"APPL_DB" : { | ||
|
@@ -77,6 +82,11 @@ | |
"id" : 14, | ||
"separator": ":", | ||
"instance" : "redis" | ||
}, | ||
"BMP_STATE_DB" : { | ||
"id" : 20, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is new database id 20 vs next in sequence 15? |
||
"separator": "|", | ||
"instance" : "redis_bmp" | ||
} | ||
}, | ||
"VERSION" : "1.0" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pterosaur How to ensure this port is not conflicting with REMOTE_DB_PORT? or does it matter?