Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202311][FRR]Adding fix for memory leak seen with BGP community #18606

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

dgsudharsan
Copy link
Collaborator

Porting PR #18272 to 202311.

Why I did it

Porting fix for FRRouting/frr#15459

Adding patch for PR FRRouting/frr#15466

Work item tracking
  • Microsoft ADO (number only):

How I did it

Ported the fix FRRouting/frr#15466 to 8.5.1

How to verify it

Running the test_stress_route and ensure no memory leak

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liat-grozovik
Copy link
Collaborator

@StormLiangMS please help to review. Tests will be completed very soon and we will to merge once done

@dgsudharsan dgsudharsan marked this pull request as ready for review April 15, 2024 15:04
@StormLiangMS
Copy link
Contributor

hi @lipxu @jimmyzhai could you help to take review this PR?

@StormLiangMS
Copy link
Contributor

StormLiangMS commented Apr 18, 2024

@StormLiangMS please help to review. Tests will be completed very soon and we will to merge once done

Have you verified with 202311 image? PR test has no gating for this one. @liat-grozovik

Copy link
Contributor

@lipxu lipxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgsudharsan
Copy link
Collaborator Author

@StormLiangMS please help to review. Tests will be completed very soon and we will to merge once done

Have you verified with 202311 image? PR test has no gating for this one. @liat-grozovik

Hi @StormLiangMS . There is no test to verify. 202305 and 202311 have identical FRR. @lipxu verified the fixes in 202305. In my opinion the testing in 202305 is sufficient.

I would also recommend adding a test to sonic-mgmt to cover this scenario.

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 2f9bc00 into sonic-net:202311 Apr 18, 2024
18 checks passed
@StormLiangMS
Copy link
Contributor

oops, 202311 should be Ying to decide to take or not, my bad. @yxieca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants