Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox] Support SKU Mellanox-SN5600-O128 #18440

Merged
merged 4 commits into from
Apr 14, 2024
Merged

[Mellanox] Support SKU Mellanox-SN5600-O128 #18440

merged 4 commits into from
Apr 14, 2024

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Mar 22, 2024 •
edited by liat-grozovik
Loading

Why I did it

Align ACS-SN5600 buffer templates to reduce redundant code
Support Mellanox-SN5600-O128

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add relevant files to support the new SKU
Update the SN5600 device files to align with the buffer configuration required.

How to verify it

Regression test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

stephenxs and others added 3 commits March 20, 2024 07:55
@stephenxs
Align the buffer templates of SN5600 to the latest ones
2daee1d 
Reduce redundant code and logic

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Add files for new Mellanox SKU
8a7760d 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Merge branch 'sonic-net:master' into align-5600-buffer-templates
6dd3cfc
@stephenxs stephenxs requested a review from keboliu March 22, 2024 07:07
@stephenxs stephenxs marked this pull request as draft March 25, 2024 11:37
@stephenxs
Remove common variable definition
2d6785a 
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs marked this pull request as ready for review April 11, 2024 06:51
@liat-grozovik liat-grozovik merged commit c076c12 into sonic-net:master Apr 14, 2024
19 checks passed
@stephenxs stephenxs deleted the align-5600-buffer-templates branch April 14, 2024 13:49
@keboliu
Copy link
Collaborator

keboliu commented Apr 22, 2024

@yxieca would you please help to cherry-pick?

@yxieca
Copy link
Contributor

yxieca commented Apr 22, 2024

@yxieca would you please help to cherry-pick?

@keboliu this seems to be a new feature code? We only take bug fixes in feature branches

@keboliu
Copy link
Collaborator

keboliu commented Apr 25, 2024

@yxieca would you please help to cherry-pick?

@keboliu this seems to be a new feature code? We only take bug fixes in feature branches

Hi @yxieca this is not a new feature, we updated some existing buffer profile to fix some issue and also added a new SKU.

@yxieca
Copy link
Contributor

yxieca commented Apr 25, 2024

@yxieca would you please help to cherry-pick?

@keboliu this seems to be a new feature code? We only take bug fixes in feature branches

Hi @yxieca this is not a new feature, we updated some existing buffer profile to fix some issue and also added a new SKU.

Mellanox-SN5600-O128 is a brand new folder, how is it a bug fix?

@yxieca
Copy link
Contributor

yxieca commented Apr 29, 2024

@yxieca would you please help to cherry-pick?

@keboliu this seems to be a new feature code? We only take bug fixes in feature branches

Hi @yxieca this is not a new feature, we updated some existing buffer profile to fix some issue and also added a new SKU.

Mellanox-SN5600-O128 is a brand new folder, how is it a bug fix?

Per offline discussion with Liat, this hardware platform already existing in 202305. The new hardware sku doesn't contain code could affect other nvidia platforms. And the new hardware sku has been tested by nvidia on 202311 branch.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Apr 29, 2024
@stephenxs @mssonicbld
[Mellanox] Support SKU Mellanox-SN5600-O128 (sonic-net#18440)
38936b2 
- Why I did it
Align ACS-SN5600 buffer templates to reduce redundant code
Support Mellanox-SN5600-O128

- How I did it
Add relevant files to support the new SKU
Update the SN5600 device files to align with the buffer configuration required.

- How to verify it
Regression test

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@mssonicbld mssonicbld mentioned this pull request Apr 29, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #18819

mssonicbld pushed a commit that referenced this pull request May 1, 2024
@stephenxs @mssonicbld
[Mellanox] Support SKU Mellanox-SN5600-O128 (#18440)
a22eb82 
- Why I did it
Align ACS-SN5600 buffer templates to reduce redundant code
Support Mellanox-SN5600-O128

- How I did it
Add relevant files to support the new SKU
Update the SN5600 device files to align with the buffer configuration required.

- How to verify it
Regression test

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keboliu keboliu keboliu approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

Assignees
No one assigned
Labels
Approved for 202311 Branch Included in 202311 Branch Request for 202311 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenxs @keboliu @yxieca @mssonicbld @liat-grozovik