Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang] Restrict AAA authorization with TACPLUS passkey #18155

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Feb 22, 2024

Why I did it

Command cannot be executed when tacacs+ in AAA authorization is set and passkey in TACPLUs is not set. There should be such restriction in YANG model definition.

Work item tracking
  • Microsoft ADO (number only): 26898399

How I did it

Add restirction

How to verify it

unit test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

qiluo-msft pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Feb 23, 2024
## Description of PR
ADO: 26898399
Summary: Update testcase per YANG model change in AAA
Fixes # (issue)

## Approach
#### What is the motivation for this PR?
Update test due to recent AAA YANG model change. sonic-net/sonic-buildimage#18155
#### How did you do it?
Add relative restriction
#### How did you verify/test it?
E2E test
@wen587
Copy link
Contributor Author

wen587 commented Feb 23, 2024

/azp run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 18155 in repo sonic-net/sonic-buildimage

@wen587
Copy link
Contributor Author

wen587 commented Feb 23, 2024

/azp run

Copy link

Commenter does not have sufficient privileges for PR 18155 in repo sonic-net/sonic-buildimage

@wen587
Copy link
Contributor Author

wen587 commented Feb 25, 2024

/AzurePipelines run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 18155 in repo sonic-net/sonic-buildimage

@qiluo-msft qiluo-msft merged commit 6224d67 into sonic-net:master Feb 27, 2024
21 checks passed
sonic-otn pushed a commit to Weitang-Zheng/sonic-buildimage that referenced this pull request Mar 11, 2024
### Why I did it
Command cannot be executed when tacacs+ in AAA authorization is set and passkey in TACPLUs is not set. There should be such restriction in YANG model definition.
##### Work item tracking
- Microsoft ADO **(number only)**: 26898399

#### How I did it
Add restirction
#### How to verify it
unit test
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Mar 12, 2024
### Why I did it
Command cannot be executed when tacacs+ in AAA authorization is set and passkey in TACPLUs is not set. There should be such restriction in YANG model definition.
##### Work item tracking
- Microsoft ADO **(number only)**: 26898399

#### How I did it
Add restirction
#### How to verify it
unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants