Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis] update service_checker module to handle database-chassis service #17836

Merged
merged 13 commits into from
Jan 24, 2024

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Jan 18, 2024

What I did:

Added change service_checker.py to add database-chassis docker also as expected running container for chassis supervisor. Change is inline with this chnage: https://github.com/sonic-net/sonic-buildimage/blob/master/files/image_config/monit/container_checker#L82

Microsoft ADO: 26655378

Why I did:
service_checker.py is used for critical process monitoring and database-chassis is critical service on Chasiss architecture on Supervisor.

How I verify:
Manual Veriifcation.

Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlhui rlhui added the P0 Priority of the issue label Jan 24, 2024
@rlhui
Copy link
Contributor

rlhui commented Jan 24, 2024

THis is needed for alert.

@rlhui rlhui merged commit 24f8f8b into sonic-net:master Jan 24, 2024
23 checks passed
@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Feb 5, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 16, 2024
…rvice (sonic-net#17836)

* Update service_checker.py

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #18119

mssonicbld pushed a commit that referenced this pull request Feb 19, 2024
…rvice (#17836)

* Update service_checker.py

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
rlhui pushed a commit that referenced this pull request Feb 21, 2024
…17836 (#18109)

PR #17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor

Signed-off-by: mlok <marty.lok@nokia.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 24, 2024
…rvice (sonic-net#17836)

* Update service_checker.py

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #18170

StormLiangMS pushed a commit that referenced this pull request Feb 25, 2024
…rvice (#17836) (#18170)

* Update service_checker.py

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Co-authored-by: abdosi <58047199+abdosi@users.noreply.github.com>
sonic-otn pushed a commit to Weitang-Zheng/sonic-buildimage that referenced this pull request Mar 11, 2024
…17836 (sonic-net#18109)

PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor

Signed-off-by: mlok <marty.lok@nokia.com>
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Mar 12, 2024
…17836 (sonic-net#18109)

PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor

Signed-off-by: mlok <marty.lok@nokia.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Apr 5, 2024
…17836 (sonic-net#18109)

PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor

Signed-off-by: mlok <marty.lok@nokia.com>
mssonicbld pushed a commit that referenced this pull request Apr 8, 2024
…17836 (#18109)

PR #17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor

Signed-off-by: mlok <marty.lok@nokia.com>
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
…rvice (sonic-net#17836)

* Update service_checker.py

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
[chassis] update service_checker module to handle database-chassis service (sonic-net#17836)
mlok-nokia added a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
…17836 (sonic-net#18109)

PR sonic-net#17836 added the container checking for database-chassis for Supervisor. But the related container_feature_dict[] is missing for the database-chassis. This causes the exception failure shows on Supervisor

Signed-off-by: mlok <marty.lok@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants