Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRR] Fix zebra memory leak when bgp fib suppress pending is enabled #17484

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

dgsudharsan
Copy link
Collaborator

Why I did it

Fix zebra leaking memory with fib suppress enabled. Porting the fix from
FRRouting/frr#14983

While running test_stress_route.py, systems with lower memory started to throw low memory logs. On further investigation, a memory leak has been found in zebra which was fixed in the FRR community.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Creating patch for with the fix

How to verify it

Running test_stress_route.py and confirming that there is no memory leak in zebra after the completion of the test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgsudharsan
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lguohan lguohan merged commit f3f5078 into sonic-net:master Dec 14, 2023
23 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 15, 2023
…onic-net#17484)

Fix zebra leaking memory with fib suppress enabled. Porting the fix from
FRRouting/frr#14983

While running test_stress_route.py, systems with lower memory started to throw low memory logs. On further investigation, a memory leak has been found in zebra which was fixed in the FRR community.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #17510

mssonicbld pushed a commit that referenced this pull request Dec 15, 2023
…17484)

Fix zebra leaking memory with fib suppress enabled. Porting the fix from
FRRouting/frr#14983

While running test_stress_route.py, systems with lower memory started to throw low memory logs. On further investigation, a memory leak has been found in zebra which was fixed in the FRR community.
@mssonicbld
Copy link
Collaborator

@dgsudharsan PR conflicts with 202311 branch

dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Feb 1, 2024
…onic-net#17484)

Fix zebra leaking memory with fib suppress enabled. Porting the fix from
FRRouting/frr#14983

While running test_stress_route.py, systems with lower memory started to throw low memory logs. On further investigation, a memory leak has been found in zebra which was fixed in the FRR community.
@dgsudharsan
Copy link
Collaborator Author

@yxieca Created PR #17977. Although fib suppression is disabled in 202311, adding this patch will ensure future patch integrations are straight forward when we cherry-pick fixes from master

yxieca pushed a commit that referenced this pull request Feb 2, 2024
…17484) (#17977)

Fix zebra leaking memory with fib suppress enabled. Porting the fix from
FRRouting/frr#14983

While running test_stress_route.py, systems with lower memory started to throw low memory logs. On further investigation, a memory leak has been found in zebra which was fixed in the FRR community.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants