-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-yang-models] Add Path Tracing attributes to SONiC Port YANG model #16758
base: master
Are you sure you want to change the base?
Conversation
@qiluo-msft could you please help and review the code of this PR? |
Hi @qiluo-msft this PR has been approved by @ganglyu and @wen587 |
Hi @qiluo-msft This PR has been reviewed and approved by two reviewers. It is ready for merge. Could you please merge the PR? |
@@ -367,4 +367,14 @@ module sonic-types { | |||
} | |||
{% else %} | |||
{% endif %} | |||
|
|||
typedef path_tracing_timestamp_template { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some additional details about templates 1-4 in this model description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kperumalbfn Many thanks for your review. I added the templates description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@cscarpitta , can you rebase and resolve the conflict. |
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
0e0ff5d
to
d6c5791
Compare
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
d6c5791
to
e8dd165
Compare
Need maintainers to merge. |
@qiluo-msft, @zhangyanzhao, @lguohan This PR has been pending merge for some time now. Could we merge this as part of 202411? The HLD (Oct 2023) and Orchagent (May 24) has been merged. |
Why I did it
To support configuration of Path Tracing attributes via YANG.
Path Tracing HLD: HLD: sonic-net/SONiC#1456
How I did it
Added Path Tracing Interface ID and Timestamp Template to the existing
sonic-port.yang
.How to verify it
Added new test cases to verify the new attributes.