Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-yang-models] Add Path Tracing attributes to SONiC Port YANG model #16758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cscarpitta
Copy link
Contributor

@cscarpitta cscarpitta commented Sep 29, 2023

Why I did it

To support configuration of Path Tracing attributes via YANG.
Path Tracing HLD: HLD: sonic-net/SONiC#1456

How I did it

Added Path Tracing Interface ID and Timestamp Template to the existing sonic-port.yang.

How to verify it

Added new test cases to verify the new attributes.

@lguohan lguohan added the YANG YANG model related changes label Sep 30, 2023
@ahsalam
Copy link

ahsalam commented Oct 14, 2023

@qiluo-msft could you please help and review the code of this PR?
This feature is tracked for 202311 release and documented by this HLD sonic-net/SONiC#1456
@zhangyanzhao

@ahsalam
Copy link

ahsalam commented Nov 13, 2023

Hi @qiluo-msft this PR has been approved by @ganglyu and @wen587
It is ready for merge, could you please merge the PR?

@cscarpitta
Copy link
Contributor Author

Hi @qiluo-msft This PR has been reviewed and approved by two reviewers. It is ready for merge. Could you please merge the PR?

@@ -367,4 +367,14 @@ module sonic-types {
}
{% else %}
{% endif %}

typedef path_tracing_timestamp_template {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some additional details about templates 1-4 in this model description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kperumalbfn Many thanks for your review. I added the templates description.

Copy link
Contributor

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kperumalbfn
kperumalbfn previously approved these changes Nov 16, 2023
@cscarpitta
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lguohan
Copy link
Collaborator

lguohan commented May 15, 2024

@cscarpitta , can you rebase and resolve the conflict.

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
@zhangyanzhao
Copy link
Collaborator

Need maintainers to merge.

@ahsalam
Copy link

ahsalam commented Aug 8, 2024

@qiluo-msft, @zhangyanzhao, @lguohan

This PR has been pending merge for some time now. Could we merge this as part of 202411?

The HLD (Oct 2023) and Orchagent (May 24) has been merged.
HLD: sonic-net/SONiC#1456
Orchagent: sonic-net/sonic-swss#2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
YANG YANG model related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants