Update CPU transmitted packets to queue 7 for chassis #16254
Conversation
|
@vmittal-msft Can you create an ADO and add the branch info to it and update the MSFT ADO number to this PR please. |
Done |
| @@ -860,3 +860,4 @@ dma_desc_aggregator_timeout_usec.BCM8869X=1000 | |||
| dma_desc_aggregator_enable_specific_MDB_LPM.BCM8869X=1 | |||
| dma_desc_aggregator_enable_specific_MDB_FEC.BCM8869X=1 | |||
| sai_pfc_dlr_init_capability=0 | |||
| sai_default_cpu_tx_tc=7 | |||
There was a problem hiding this comment.
why we need this property ? this should be controlled from SAI sonic-net/sonic-swss@04f84fc
There was a problem hiding this comment.
@vmittal-msft , can you clarify what is the current behavior without this "default" BCM configuration specification?
Would it be up to the BRCM HWSKUs' decision on setting its own default if this is not specified?
@abdosi , Do we currently set this as part of the port attribute during port bring up? If we are not doing it currently, then having a "specified" default setting would be better than don't have it right? Otherwise, we have no way of knowing which BRCM based HWSKU default setting...
There was a problem hiding this comment.
This property is needed as part of the BRCM fix for CPU to send LACP/BGP/LLDP packets on queue-7. In the absence of this property and sai fix, cpu will send packets to queue-0. for XGS platforms, we don't need this as cpu tx packets goes to queue-7.
There was a problem hiding this comment.
i need to check with BRCM if this capability is supported in sai release and can be used instead.
There was a problem hiding this comment.
@vmittal-msft - we should request DNX SAI to support this SAI attribute.
|
@yxieca , @StormLiangMS , |
|
@vmittal-msft PR conflicts with 202211 branch |
|
@vmittal-msft PR conflicts with 202205 branch |
|
@vmittal-msft , Please raise PR for the corresponding branch that exhibit cherry-pick conflict for both 202205 and 202211 |
|
@vmittal-msft PR conflicts with 202305 branch |
* Update CPU transmitted packets to TC = 7 for SONIC chassis * Added new SOC property to permitted list
|
@vmittal-msft @gechiang conflict with 202305, need separate PR. |
|
@vmittal-msft @gechiang remind for 202305 cherry pick |
Why I did it
Update CPU transmitted packets to q=7 so it doesn't get impacted by other lossy traffic
Work item tracking
How I did it
Updated config file for affected HWSKUs as well as saibcm
How to verify it
It is verified on sonic chassis to be working fine.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)