[pfcwd]: add flag to enable pfc wd on start #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihui Han <sihan@microsoft.com>
lguohan
reviewed
Feb 28, 2018
Makefile
Outdated
| @@ -8,6 +8,7 @@ | |||
| # * ENABLE_DHCP_GRAPH_SERVICE: Enables get-graph service to fetch minigraph files | |||
| # through http. | |||
| # * SHUTDOWN_BGP_ON_START: Sets admin-down state for all bgp peerings after restart. | |||
| # * ENABLE_PFC_WD_ON_START: Enable PFCWD on server-facing ports when starts. | |||
There was a problem hiding this comment.
use PFCWD consistently throughout the CR?
There was a problem hiding this comment.
Enable PFC WatchDog (PFCWD) on server-facing ports by default for TOR switch.
lguohan
reviewed
Feb 28, 2018
| @@ -168,6 +168,10 @@ sudo bash -c "echo enabled=false > $FILESYSTEM_ROOT/etc/sonic/updategraph.conf" | |||
| {% if shutdown_bgp_on_start == "y" %} | |||
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_bgp_status\": \"down\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" | |||
| {% endif %} | |||
| {% if enable_pfc_wd_on_start == "y" %} | |||
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_pfc_wd_status\": \"enable\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" | |||
There was a problem hiding this comment.
which agent is reading this DEVICE_METADATA default_pfc_wd_status, where is that code?
There was a problem hiding this comment.
There was a problem hiding this comment.
if the PR is related/depended to other PR, can you mark this information in the PR comments?
jleveque
reviewed
Feb 28, 2018
Makefile
Outdated
| @@ -8,6 +8,7 @@ | |||
| # * ENABLE_DHCP_GRAPH_SERVICE: Enables get-graph service to fetch minigraph files | |||
| # through http. | |||
| # * SHUTDOWN_BGP_ON_START: Sets admin-down state for all bgp peerings after restart. | |||
| # * ENABLE_PFC_WD_ON_START: Enable PFCWD on server-facing ports when starts. | |||
There was a problem hiding this comment.
Suggest change to ENABLE_PFC_WD_ON_START: Enable PFC Watchdog on server-facing ports when SONiC starts. for clarity.
jleveque
reviewed
Feb 28, 2018
rules/config
Outdated
| @@ -36,6 +36,10 @@ DEFAULT_PASSWORD = YourPaSsWoRd | |||
| # bgp service starts. | |||
| # SHUTDOWN_BGP_ON_START = y | |||
|
|
|||
| # ENABLE_PFC_WD_ON_START - if set to y PFC WD will be enabled all server-facing ports when | |||
There was a problem hiding this comment.
Suggest changing WD to Watchdog for clarity.
Signed-off-by: Sihui Han <sihan@microsoft.com>
lguohan
reviewed
Mar 2, 2018
| @@ -168,6 +168,10 @@ sudo bash -c "echo enabled=false > $FILESYSTEM_ROOT/etc/sonic/updategraph.conf" | |||
| {% if shutdown_bgp_on_start == "y" %} | |||
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_bgp_status\": \"down\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" | |||
| {% endif %} | |||
| {% if enable_pfcwd_on_start == "y" %} | |||
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_pfc_wd_status\": \"enable\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" | |||
There was a problem hiding this comment.
to be consistent, this should also be default_pfcwd_status
Signed-off-by: Sihui Han <sihan@microsoft.com>
Makefile
Outdated
| @@ -63,7 +64,7 @@ SONIC_BUILD_INSTRUCTION := make \ | |||
| BUILD_NUMBER=$(BUILD_NUMBER) \ | |||
| ENABLE_DHCP_GRAPH_SERVICE=$(ENABLE_DHCP_GRAPH_SERVICE) \ | |||
| SHUTDOWN_BGP_ON_START=$(SHUTDOWN_BGP_ON_START) \ | |||
| ENABLE_PFC_WD_ON_START=$(ENABLE_PFC_WD_ON_START) \ | |||
| ENABLE_PFCWD_ON_START=$(ENABLE_PFCWD_ON_START) \ | |||
There was a problem hiding this comment.
This will always rewrite value in config file
There was a problem hiding this comment.
4 tasks
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
Warn user while deleting VLAN if it has IP addresses. Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han sihan@microsoft.com
- What I did
Add flag to enable pfc wd on start
- How I did it
Add the option to enable pfc wd on start
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)